fix!: Remove distinction of enum and flags-enum for ShapeTag - #65
Conversation
Unified the ShapeTag prefix generation for regular enums and [Flags] enums under "enum:", removing the "flags:" prefix entirely and deleting the unused HasFlagsAttribute helper method. Updated the tests to match.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
ShapeTag
ShapeTagShapeTag
ShapeTagShapeTag
This change removes the distinction between enum and flags-enum for the ShapeTag generation, ensuring that both regular and [Flags] enums are prefixed with "enum:" in ShapeTags. It also cleans up the unused HasFlagsAttribute method from ZeroSerializerGenerator.cs, and updates corresponding assertions in ShapeTagAndHashTests.cs.
PR created automatically by Jules for task 10708314756535983563 started by @sator-imaging