-
Notifications
You must be signed in to change notification settings - Fork 0
Add _AsValue accessors for blittable nested struct properties #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
sator-imaging
wants to merge
8
commits into
main
from
codex/add-_asvalue-for-blittable-struct-properties
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c6a5870
Add value accessors for blittable properties
sator-imaging 9ce6cc6
Test non-blittable structs omit value accessors
sator-imaging ccff39a
Co-locate blittable view and value generation
sator-imaging 5a34053
Inline blittable value property generation
sator-imaging 02a9212
Preserve existing view generation call
sator-imaging 16a98e6
Limit value accessors to strict blittable views
sator-imaging c33592c
Emit strict value accessor beside view getter
sator-imaging 9e1afbe
Cover mixed properties on non-blittable views
sator-imaging File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Prevent
_AsValuename collisions in generated Views.A valid blittable struct can declare a public property named
Nested_AsValue. This line then generates anotherNested_AsValueproperty forNested, which causes a duplicate-member compile error in the generated View. Reserve the_AsValuesuffix or report a generator diagnostic before emitting the accessor. Add a regression test for this valid model shape.🤖 Prompt for AI Agents