Skip to content

fix(kitchen-sink): show "No results" only after search is submitted #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sathergate merged 1 commit into from
Mar 30, 2026
Merged

fix(kitchen-sink): show "No results" only after search is submitted #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion examples/kitchen-sink/app/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,15 @@ export default function Home() {
>([]);
const [loading, setLoading] = useState(false);
const [error, setError] = useState<string | null>(null);
const [hasSearched, setHasSearched] = useState(false);

async function handleSearch(e: React.FormEvent) {
e.preventDefault();
if (!query.trim()) return;

setError(null);
setLoading(true);
setHasSearched(true);
try {
const res = await fetch(
`/api/search?q=${encodeURIComponent(query)}&fuzzy=true`,
Expand Down Expand Up @@ -86,7 +88,7 @@ export default function Home() {
<p style={{ color: "red", marginTop: 12 }}>{error}</p>
)}

{results.length === 0 && query.trim() && !loading && !error && (
{results.length === 0 && hasSearched && !loading && !error && (
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Guard empty-state message when query is blank

Removing the query.trim() check makes the empty-state render for an empty input after any prior no-result search, because hasSearched stays true and results stays empty. In that flow, clearing the field shows No results found for '', which is misleading and regresses prior behavior where blank queries suppressed the message.

Useful? React with 👍 / 👎.

<p style={{ color: "#888", marginTop: 12 }}>No results found for &apos;{query}&apos;</p>
)}

Expand Down
Loading