Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug which affected the Neuroparl-ST evaluations, and updates the resulting scores.
Bug Description
Previously, following the original paper script,
ne_terms_accuracy.pyrequired.txtfor input. These were originally created by usingjqand selecting theoutputkeys on the.jsonoutput logs, saving into temporary files.This however caused some issues, because in some cases
\nappeared onoutput, leading to a erroneous segmentation and correspondence between source and target sentences.Solution
The
ne_terms_accuracy.pynow directly loads the output.jsonfiles.