Repository navigation
fix(release): check out the tag, never a branch of the same name - #9
Merged
Merged
Conversation
The build jobs checked out the release by its short name. actions/checkout prefers a branch over a tag with the same name, so with a v1.0.0 branch in the repository the release would have built that branch instead of the tagged commit. Every checkout now uses the full refs/tags/ reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build jobs checked out the release by its short name. actions/checkout prefers a branch over a tag with the same name, so with a v1.0.0 branch in the repository the release would have built that branch instead of the tagged commit. Every checkout now uses the full refs/tags/ reference.
What this changes
Why
How it was tested
Checklist
cargo fmt --all --check,cargo clippy --workspace --all-targets --locked -- -D warnings, andcargo test --workspace --lockedpassnpm run format:check,npm run typecheck, andnpm testpassdocs/is updated, and user-visible changes are listed under "Unreleased" inCHANGELOG.md