[pull] main from aidenybai:main - #113
Merged
Merged
Conversation
…ption (#478) * Extend copy context past shared-UI wrappers and add maxContextLines option Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com> * Align CLI maxContextLines description with restored option semantics Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com> * Harden maxContextLines against non-finite values that disabled the trace cap Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com> * Collapse consecutive duplicate trace lines from shared-UI frames Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com> * Document trace hardening in changeset Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com> * Trim duplicated rationale comments in context budget logic Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com> * Scope shared-UI detection to components/ui and packages/ui A bare `/ui/` segment also matched Next's `app/ui/` feature convention, demoting real feature code to budget-free and inflating the trace. Narrow to the actual shared-UI conventions, document the maxContextLines budget edge cases, and add an e2e test covering the option end-to-end. * fix * Make install-skill test path assertions cross-platform The skill source path and removal dirs are built with node:path.join / fileURLToPath, which emit backslashes on Windows. Assert against join() output instead of hardcoded forward-slash paths so the test passes on windows-latest. --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )