Move oxlint suppressions inline - #1344
Open
stipsan wants to merge 7 commits into
Open
Conversation
Co-authored-by: Cody Olsen <stipsan@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 84ed0e4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
stipsan
marked this pull request as ready for review
June 19, 2026 07:24
stipsan
requested review from
Copilot and
pedrobonamin
and removed request for
a team
June 19, 2026 07:24
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates oxlint suppressions away from .oxlintrc.json (ignorePatterns/overrides) into inline // oxlint-disable... and // @ts-expect-error... comments across several legacy packages, and documents the preferred suppression approach for future work.
Changes:
- Removed legacy
.oxlintrc.jsonoverrides and broad ignores for several packages, relying on inline suppressions instead. - Added file-level (and a few line-level)
oxlint-disable/@ts-expect-errorcomments in affected legacy files to keeppnpm lintpassing. - Documented inline suppression guidance in
AGENTS.mdand added an “empty” changeset for the maintenance work.
Reviewed changes
Copilot reviewed 235 out of 236 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| turbo/generators/src/config.ts | Add file-level oxlint suppressions for legacy diagnostics |
| plugins/sanity-plugin-mux-input/v2-incompatible.js | Add file-level oxlint suppression for CommonJS import |
| plugins/sanity-plugin-mux-input/src/util/types.ts | Add file-level oxlint suppressions for legacy TS type issues |
| plugins/sanity-plugin-mux-input/src/util/tryWithSuspend.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-mux-input/src/util/textTracks.ts | Add file-level oxlint suppression for await-in-loop |
| plugins/sanity-plugin-mux-input/src/util/getPosterSrc.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-mux-input/src/util/formatSeconds.ts | Remove broad eslint-disable comment |
| plugins/sanity-plugin-mux-input/src/util/formatBytes.ts | Remove broad eslint-disable comment |
| plugins/sanity-plugin-mux-input/src/util/extractFiles.ts | Add file-level oxlint suppression for unused vars |
| plugins/sanity-plugin-mux-input/src/util/createSearchFilter.ts | Add file-level oxlint suppression for restricted imports |
| plugins/sanity-plugin-mux-input/src/util/asserters.ts | Add file-level oxlint suppression for unnecessary type args |
| plugins/sanity-plugin-mux-input/src/hooks/useSecretsFormState.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-mux-input/src/hooks/useMuxPolling.ts | Add file-level oxlint suppressions for legacy promise/type issues |
| plugins/sanity-plugin-mux-input/src/hooks/useMuxAssets.ts | Add file-level oxlint suppression(s); remove one eslint-disable-next-line |
| plugins/sanity-plugin-mux-input/src/hooks/useMediaMetadata.ts | Add file-level oxlint suppressions for legacy React/DOM patterns |
| plugins/sanity-plugin-mux-input/src/hooks/useInView.ts | Add file-level oxlint suppression; remove empty eslint-disable-next-line |
| plugins/sanity-plugin-mux-input/src/hooks/useFetchFileSize.ts | Add file-level oxlint suppressions for legacy React/promise patterns |
| plugins/sanity-plugin-mux-input/src/hooks/useCancelUpload.ts | Add file-level oxlint suppression for floating promises |
| plugins/sanity-plugin-mux-input/src/hooks/useAssets.ts | Add file-level oxlint suppressions for legacy spread/type assertions |
| plugins/sanity-plugin-mux-input/src/hooks/useAssetDocumentValues.ts | Add file-level oxlint suppression for unnecessary type assertion |
| plugins/sanity-plugin-mux-input/src/context/DrmPlaybackWarningContext.tsx | Add file-level oxlint suppressions for constructed context values/deprecations |
| plugins/sanity-plugin-mux-input/src/context/DialogStateContext.tsx | Add file-level oxlint suppression for constructed context values |
| plugins/sanity-plugin-mux-input/src/components/withFocusRing/withFocusRing.ts | Add file-level oxlint suppressions for deprecated/unsafe typing |
| plugins/sanity-plugin-mux-input/src/components/VideoThumbnail.tsx | Add file-level oxlint suppressions for React compiler/deprecations |
| plugins/sanity-plugin-mux-input/src/components/VideosBrowser.tsx | Add file-level oxlint suppression for deprecations |
| plugins/sanity-plugin-mux-input/src/components/VideoPlayer.tsx | Add file-level oxlint suppressions for unused vars / React compiler |
| plugins/sanity-plugin-mux-input/src/components/VideoMetadata.tsx | Add file-level oxlint suppression for deprecations |
| plugins/sanity-plugin-mux-input/src/components/VideoInBrowser.tsx | Add file-level oxlint suppression for deprecations |
| plugins/sanity-plugin-mux-input/src/components/VideoDetails/VideoDetails.tsx | Add file-level oxlint suppression for deprecations |
| plugins/sanity-plugin-mux-input/src/components/VideoDetails/DeleteDialog.tsx | Add file-level oxlint suppressions for React compiler/deprecations |
| plugins/sanity-plugin-mux-input/src/components/UploadProgress.tsx | Add file-level oxlint suppressions for legacy TS issues |
| plugins/sanity-plugin-mux-input/src/components/UploadPlaceholder.tsx | Add file-level oxlint suppression for deprecations |
| plugins/sanity-plugin-mux-input/src/components/Uploader.tsx | Add file-level oxlint suppressions; remove one eslint-disable-next-line |
| plugins/sanity-plugin-mux-input/src/components/Uploader.styled.tsx | Replace eslint-disable with oxlint suppression |
| plugins/sanity-plugin-mux-input/src/components/uploadConfiguration/StaticRenditionSelector.tsx | Add file-level oxlint suppression for deprecations |
| plugins/sanity-plugin-mux-input/src/components/uploadConfiguration/ResolutionTierSelector.tsx | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-mux-input/src/components/uploadConfiguration/PlaybackPolicyOption.tsx | Add file-level oxlint suppression for a11y rule |
| plugins/sanity-plugin-mux-input/src/components/UploadConfiguration.tsx | Add file-level oxlint suppressions; remove one eslint-disable-next-line |
| plugins/sanity-plugin-mux-input/src/components/TextTracksManager.tsx | Add file-level oxlint suppressions for React compiler/deprecations |
| plugins/sanity-plugin-mux-input/src/components/TextTracksEditor.tsx | Add file-level oxlint suppression for deprecations |
| plugins/sanity-plugin-mux-input/src/components/SelectSortOptions.tsx | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-mux-input/src/components/ResyncMetadata.tsx | Add file-level oxlint suppressions for legacy TS template/promise issues |
| plugins/sanity-plugin-mux-input/src/components/PlayerActionsMenu.tsx | Add file-level oxlint suppressions for React compiler/deprecations |
| plugins/sanity-plugin-mux-input/src/components/Player.tsx | Add file-level oxlint suppression; remove eslint-disable-next-line no-warning-comments |
| plugins/sanity-plugin-mux-input/src/components/Onboard.tsx | Add file-level oxlint suppression for deprecations |
| plugins/sanity-plugin-mux-input/src/components/ImportVideosFromMux.tsx | Add file-level oxlint suppressions; remove eslint-disable-next-line complexity |
| plugins/sanity-plugin-mux-input/src/components/FormField.tsx | Add file-level oxlint suppression for deprecations |
| plugins/sanity-plugin-mux-input/src/components/FileInputMenuItem.tsx | Add file-level oxlint suppressions for restricted imports/deprecations |
| plugins/sanity-plugin-mux-input/src/components/FileInputMenuItem.styled.tsx | Add file-level oxlint suppression for deprecations |
| plugins/sanity-plugin-mux-input/src/components/ErrorBoundaryCard.tsx | Add file-level oxlint suppressions for legacy React/TS patterns |
| plugins/sanity-plugin-mux-input/src/components/EditThumbnailDialog.tsx | Add file-level oxlint suppressions; remove eslint-disable-next-line no-warning-comments |
| plugins/sanity-plugin-mux-input/src/components/EditCaptionDialog.tsx | Add file-level oxlint suppressions for legacy typing/conversions |
| plugins/sanity-plugin-mux-input/src/components/DraggableWatermark.tsx | Add file-level oxlint suppressions for React compiler/DOM listeners/typing |
| plugins/sanity-plugin-mux-input/src/components/documentPreview/TimeAgo.tsx | Add file-level oxlint suppression for deprecations |
| plugins/sanity-plugin-mux-input/src/components/documentPreview/PaneItemPreview.tsx | Add file-level oxlint suppressions for restricted imports/deprecations |
| plugins/sanity-plugin-mux-input/src/components/documentPreview/DocumentPreview.tsx | Add file-level oxlint suppressions for React compiler/unsafe assertions |
| plugins/sanity-plugin-mux-input/src/components/ConfigureApi.tsx | Add file-level oxlint suppressions for promise/TS legacy issues |
| plugins/sanity-plugin-mux-input/src/components/AddCaptionDialog.tsx | Add file-level oxlint suppression for deprecations |
| plugins/sanity-plugin-mux-input/src/actions/upload.ts | Add file-level oxlint suppressions; remove several eslint-disable-next-line comments |
| plugins/sanity-plugin-mux-input/src/actions/secrets.ts | Add file-level oxlint suppressions; remove eslint-disable-next-line max-params |
| plugins/sanity-plugin-mux-input/src/actions/assets.ts | Add file-level oxlint suppression for unused vars |
| plugins/sanity-plugin-mux-input/src/_exports/index.ts | Add file-level oxlint suppressions for deprecations/spread fallback |
| plugins/sanity-plugin-media/vitest.setup.ts | Add file-level oxlint suppression for unassigned import |
| plugins/sanity-plugin-media/v2-incompatible.js | Add file-level oxlint suppression for CommonJS import |
| plugins/sanity-plugin-media/src/utils/zodFormResolver.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-media/src/utils/uploadSanityAsset.ts | Add file-level oxlint suppressions for deprecated/unsafe/DOM listener patterns |
| plugins/sanity-plugin-media/src/utils/typeGuards.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-media/src/utils/typeGuards.test.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-media/src/utils/mediaField.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-media/src/utils/imageDprUrl.test.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-media/src/utils/getUniqueDocuments.test.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-media/src/utils/getTagSelectOptions.test.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-media/src/utils/getSchemeColor.ts | Add file-level oxlint suppression for deprecations |
| plugins/sanity-plugin-media/src/utils/getDocumentAssetIds.test.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-media/src/utils/getAssetResolution.test.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-media/src/utils/generatePreviewBlobUrl.ts | Add file-level oxlint suppression for prefer-add-event-listener |
| plugins/sanity-plugin-media/src/utils/generatePreviewBlobUrl.test.ts | Add file-level oxlint suppressions; remove eslint-disable block in stub |
| plugins/sanity-plugin-media/src/utils/constructFilter.test.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-media/src/utils/blocksToText.test.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-media/src/utils/applyMediaTags.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-media/src/types/sanity-ui.d.ts | Add file-level oxlint suppression; remove eslint-disable-next-line |
| plugins/sanity-plugin-media/src/styled/react-select/single.tsx | Add file-level oxlint suppressions for nested components/deprecations |
| plugins/sanity-plugin-media/src/styled/react-select/creatable.tsx | Add file-level oxlint suppressions for nested components/deprecations |
| plugins/sanity-plugin-media/src/operators/debugThrottle.ts | Add file-level oxlint suppression for deprecations |
| plugins/sanity-plugin-media/src/operators/checkTagName.ts | Add file-level oxlint suppressions for deprecated/unsafe assertions |
| plugins/sanity-plugin-media/src/operators/checkTagName.test.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-media/src/modules/uploads/index.ts | Add file-level oxlint suppression for deprecations |
| plugins/sanity-plugin-media/src/modules/uploads/index.test.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-media/src/modules/uploads/epics.test.ts | Add file-level oxlint suppressions for unbound method / unsafe assertions |
| plugins/sanity-plugin-media/src/modules/tags/index.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-media/src/modules/tags/index.test.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-media/src/modules/tags/epics.test.ts | Add file-level oxlint suppression for unbound method |
| plugins/sanity-plugin-media/src/modules/selectors.test.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-media/src/modules/search/index.test.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-media/src/modules/notifications/reducer.test.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-media/src/modules/notifications/index.ts | Add file-level oxlint suppressions for deprecated/unsafe conversions |
| plugins/sanity-plugin-media/src/modules/notifications/epics.test.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-media/src/modules/index.ts | Add file-level oxlint suppression for unnecessary type arguments |
| plugins/sanity-plugin-media/src/modules/dialog/reducer.test.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-media/src/modules/dialog/index.ts | Add file-level oxlint suppression for unsafe optional chaining |
| plugins/sanity-plugin-media/src/modules/dialog/epics.test.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-media/src/modules/assets/tagsAndListenerEpics.test.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-media/src/modules/assets/reducer.test.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-media/src/modules/assets/index.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-media/src/modules/assets/fetchEpic.test.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-media/src/modules/assets/deleteAndUpdateEpics.test.ts | Add file-level oxlint suppressions for unsafe assertions/unbound method |
| plugins/sanity-plugin-media/src/hooks/useOnScreen.ts | Add file-level oxlint suppression for exhaustive-deps |
| plugins/sanity-plugin-media/src/hooks/useBreakpointIndex.ts | Add file-level oxlint suppressions for unused vars/exhaustive-deps/deprecations |
| plugins/sanity-plugin-media/src/contexts/ToolOptionsContext.tsx | Add file-level oxlint suppression for React compiler |
| plugins/sanity-plugin-media/src/contexts/DropzoneDispatchContext.tsx | Add file-level oxlint suppression for constructed context values |
| plugins/sanity-plugin-media/src/contexts/AssetSourceDispatchContext.tsx | Add file-level oxlint suppression for constructed context values |
| plugins/sanity-plugin-media/src/components/UploadDropzone/index.tsx | Add file-level oxlint suppressions for await-in-loop/unused vars/unsafe assertions |
| plugins/sanity-plugin-media/src/components/TextInputNumber/index.tsx | Add file-level oxlint suppression for redundant type constituents |
| plugins/sanity-plugin-media/src/components/TagViewHeader/index.tsx | Add file-level oxlint suppression for deprecations |
| plugins/sanity-plugin-media/src/components/TagView/index.tsx | Add file-level oxlint suppression for unnecessary type conversion |
| plugins/sanity-plugin-media/src/components/TagsVirtualized/index.tsx | Add file-level oxlint suppressions for map-spread/nested components |
| plugins/sanity-plugin-media/src/components/Tag/index.tsx | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-media/src/components/TableRowUpload/index.tsx | Add file-level oxlint suppression for deprecations |
| plugins/sanity-plugin-media/src/components/TableRowAsset/index.tsx | Add file-level oxlint suppression; remove eslint-disable-next-line complexity |
| plugins/sanity-plugin-media/src/components/TableHeader/index.tsx | Add file-level oxlint suppression for deprecations |
| plugins/sanity-plugin-media/src/components/SearchFacetTags/index.tsx | Add file-level oxlint suppressions for index keys/deprecations/unsafe assertions |
| plugins/sanity-plugin-media/src/components/SearchFacetString/index.tsx | Add file-level oxlint suppression for index keys |
| plugins/sanity-plugin-media/src/components/SearchFacetSelect/index.tsx | Add file-level oxlint suppression for index keys |
| plugins/sanity-plugin-media/src/components/SearchFacetsControl/index.tsx | Add file-level oxlint suppressions for index keys/deprecations |
| plugins/sanity-plugin-media/src/components/SearchFacets/index.tsx | Add file-level oxlint suppression for deprecations |
| plugins/sanity-plugin-media/src/components/SearchFacetNumber/index.tsx | Add file-level oxlint suppression for index keys |
| plugins/sanity-plugin-media/src/components/SearchFacet/index.tsx | Add file-level oxlint suppression for deprecations |
| plugins/sanity-plugin-media/src/components/ReduxProvider/index.tsx | Add file-level oxlint suppression for deprecations |
| plugins/sanity-plugin-media/src/components/OrderSelect/index.tsx | Add file-level oxlint suppressions for index keys/deprecations |
| plugins/sanity-plugin-media/src/components/Notifications/index.tsx | Add file-level oxlint suppression for exhaustive-deps |
| plugins/sanity-plugin-media/src/components/Items/index.tsx | Add file-level oxlint suppression for exhaustive-deps |
| plugins/sanity-plugin-media/src/components/Image/index.tsx | Add file-level oxlint suppression for deprecations |
| plugins/sanity-plugin-media/src/components/FormFieldInputLabel/index.tsx | Add file-level oxlint suppression for deprecations |
| plugins/sanity-plugin-media/src/components/FormBuilderTool/index.tsx | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-media/src/components/FormBuilderTool/FormBuilderTool.test.tsx | Add file-level oxlint suppressions for deprecated/unsafe assertions |
| plugins/sanity-plugin-media/src/components/FileIcon/index.tsx | Add file-level oxlint suppressions for deprecated/unsafe assertions |
| plugins/sanity-plugin-media/src/components/FileAssetPreview/index.tsx | Add file-level oxlint suppression for media-has-caption |
| plugins/sanity-plugin-media/src/components/DocumentList/index.tsx | Add file-level oxlint suppression for deprecations |
| plugins/sanity-plugin-media/src/components/DialogTags/index.tsx | Add file-level oxlint suppressions for exhaustive-deps/React compiler |
| plugins/sanity-plugin-media/src/components/DialogTagEdit/index.tsx | Add file-level oxlint suppressions for a11y/nested components/unsafe assertions |
| plugins/sanity-plugin-media/src/components/DialogTagCreate/index.tsx | Add file-level oxlint suppressions for a11y/nested components/React compiler |
| plugins/sanity-plugin-media/src/components/DialogSearchFacets/index.tsx | Add file-level oxlint suppressions for exhaustive-deps/React compiler |
| plugins/sanity-plugin-media/src/components/DialogConfirm/index.tsx | Add file-level oxlint suppressions for nested components/React compiler/deprecations |
| plugins/sanity-plugin-media/src/components/DialogAssetEdit/index.tsx | Add file-level oxlint suppressions for a11y/nested components/typing/deprecations |
| plugins/sanity-plugin-media/src/components/DialogAssetEdit/DialogAssetEdit.test.tsx | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-media/src/components/DialogAssetEdit/Details.tsx | Add file-level oxlint suppressions for deprecated/unsafe assertions |
| plugins/sanity-plugin-media/src/components/Controls/index.tsx | Add file-level oxlint suppression for deprecations |
| plugins/sanity-plugin-media/src/components/CardAsset/index.tsx | Add file-level oxlint suppressions for a11y/deprecations |
| plugins/sanity-plugin-media/src/components/CardAsset/CardAsset.test.tsx | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-media/src/components/ButtonViewGroup/index.tsx | Add file-level oxlint suppression for deprecations |
| plugins/sanity-plugin-media/src/components/Browser/useBrowserInit.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-media/src/components/Browser/Browser.test.tsx | Add file-level oxlint suppression for deprecations |
| plugins/sanity-plugin-media/src/components/AutoTagInputWrapper/index.tsx | Add file-level oxlint suppressions for exhaustive-deps/unsafe assertions |
| plugins/sanity-plugin-media/src/components/AssetTableVirtualized/index.tsx | Add file-level oxlint suppression for nested components |
| plugins/sanity-plugin-media/src/components/AssetMetadata/index.tsx | Add file-level oxlint suppressions for unsafe optional chaining/deprecations |
| plugins/sanity-plugin-media/src/components/AssetGridVirtualized/index.tsx | Add file-level oxlint suppression for nested components |
| plugins/sanity-plugin-media/src/tests/fixtures/renderWithProviders.tsx | Add file-level oxlint suppression for deprecations |
| plugins/sanity-plugin-media/src/tests/fixtures/mockSanityClient.ts | Add file-level oxlint suppressions for legacy TS/spread issues |
| plugins/sanity-plugin-media/src/tests/fixtures/createEpicTestStore.ts | Add file-level oxlint suppression for deprecations |
| plugins/sanity-plugin-media/scripts/migrate-to-localized-fields.ts | Add @ts-expect-error for legacy typing in migration patch |
| plugins/sanity-plugin-dashboard-widget-vercel/src/machines/refresh.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-dashboard-widget-vercel/src/machines/form.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-dashboard-widget-vercel/src/machines/dialog.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-dashboard-widget-vercel/src/machines/deploymentTargetList.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-dashboard-widget-vercel/src/machines/deploy.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-cloudinary/src/components/WidgetInput.tsx | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-cloudinary/src/components/CloudinaryInput.tsx | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-cloudinary/src/components/AssetListFunctions.tsx | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-plugin-cloudinary/src/components/asset-source/CloudinaryAssetSource.tsx | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-naive-html-serializer/src/BaseSerializationConfig.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-naive-html-serializer/src/BaseDocumentSerializer/index.ts | Add file-level oxlint suppressions for unsafe assertions/template expressions |
| plugins/sanity-naive-html-serializer/src/BaseDocumentMerger.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-naive-html-serializer/src/BaseDocumentDeserializer/helpers.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/sanity-naive-html-serializer/src/BaseDocumentDeserializer/BaseDocumentDeserializer.ts | Add file-level oxlint suppression for template expressions |
| plugins/@sanity/personalization-plugin/src/launchDarkly/utils.ts | Add file-level oxlint suppression for await-in-loop |
| plugins/@sanity/personalization-plugin/src/launchDarkly/components/Secrets.tsx | Add file-level oxlint suppression for unsafe type assertion |
| plugins/@sanity/personalization-plugin/src/growthbook/utils.ts | Add file-level oxlint suppression for await-in-loop |
| plugins/@sanity/personalization-plugin/src/growthbook/Components/Secrets.tsx | Add file-level oxlint suppression for unsafe type assertion |
| plugins/@sanity/personalization-plugin/src/components/VariantPreview.tsx | Add file-level oxlint suppression for unsafe type assertion |
| plugins/@sanity/personalization-plugin/src/components/ExperimentItem.tsx | Add file-level oxlint suppression for unsafe type assertion |
| plugins/@sanity/personalization-plugin/src/components/ExperimentInput.tsx | Add file-level oxlint suppressions for base-to-string/unsafe assertions |
| plugins/@sanity/personalization-plugin/src/components/ExperimentField.tsx | Add file-level oxlint suppression for unsafe type assertion |
| plugins/@sanity/personalization-plugin/src/components/Array.tsx | Add file-level oxlint suppressions for unsafe assertions/template expressions |
| plugins/@sanity/hierarchical-document-list/src/utils/treePatches.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/@sanity/hierarchical-document-list/src/utils/gradientPatchAdapter.ts | Add file-level oxlint suppression for unsafe type assertion |
| plugins/@sanity/hierarchical-document-list/src/TreeDeskStructure.tsx | Add file-level oxlint suppression for unsafe type assertion |
| plugins/@sanity/hierarchical-document-list/src/components/TreeNodeRendererScaffold.tsx | Add file-level oxlint suppression for array index keys |
| plugins/@sanity/hierarchical-document-list/src/components/TreeNodeRenderer.tsx | Add file-level oxlint suppression for unsafe type assertion |
| plugins/@sanity/hierarchical-document-list/src/components/TreeEditor.tsx | Add file-level oxlint suppression for unsafe type assertion |
| plugins/@sanity/hierarchical-document-list/src/components/NodeActions.tsx | Add file-level oxlint suppression for nested components |
| plugins/@sanity/hierarchical-document-list/src/components/DocumentInNode.tsx | Add file-level oxlint suppressions for nested components/unsafe assertions |
| plugins/@sanity/hierarchical-document-list/src/components/DeskWarning.tsx | Add file-level oxlint suppression for array index keys |
| plugins/@sanity/google-maps-input/src/plugin.tsx | Add file-level oxlint suppression for unsafe type assertion |
| plugins/@sanity/google-maps-input/src/map/SearchInput.tsx | Add file-level oxlint suppression for deprecations |
| plugins/@sanity/google-maps-input/src/map/Marker.tsx | Add file-level oxlint suppression for deprecations |
| plugins/@sanity/google-maps-input/src/map/Arrow.tsx | Add file-level oxlint suppression for deprecations |
| plugins/@sanity/google-maps-input/src/input/GeopointRadiusSelect.tsx | Add file-level oxlint suppression for deprecations |
| plugins/@sanity/google-maps-input/src/input/GeopointRadiusInput.tsx | Add file-level oxlint suppression for deprecations |
| plugins/@sanity/google-maps-input/src/input/GeopointInput.tsx | Add file-level oxlint suppression for deprecations |
| plugins/@sanity/google-maps-input/src/diff/GeopointRadiusMove.tsx | Add file-level oxlint suppression for deprecations |
| plugins/@sanity/google-maps-input/src/diff/GeopointMove.tsx | Add file-level oxlint suppression for deprecations |
| plugins/@sanity/embeddings-index-ui/src/utils/types.ts | Add @ts-expect-error for legacy Sanity type import |
| plugins/@sanity/embeddings-index-ui/src/schemas/typeDefExtensions.ts | Add file-level oxlint suppression for unassigned import; remove eslint-disable |
| plugins/@sanity/embeddings-index-ui/src/referenceInput/SemanticSearchReferenceInput.tsx | Add file-level oxlint suppression and multiple @ts-expect-error annotations |
| plugins/@sanity/embeddings-index-ui/src/referenceInput/SemanticSearchAutocomplete.tsx | Add file-level oxlint suppression and @ts-expect-error; remove eslint-disable |
| plugins/@sanity/embeddings-index-ui/src/referenceInput/referencePlugin.tsx | Add file-level oxlint suppression and @ts-expect-error annotations |
| plugins/@sanity/embeddings-index-ui/src/preview/DocumentPreview.tsx | Add file-level oxlint suppression and @ts-expect-error for legacy typings |
| plugins/@sanity/embeddings-index-ui/src/index.ts | Add file-level oxlint suppression for unassigned import |
| plugins/@sanity/embeddings-index-ui/src/embeddingsIndexDashboard/QueryIndex.tsx | Add @ts-expect-error annotations for legacy types |
| plugins/@sanity/embeddings-index-ui/src/embeddingsIndexDashboard/IndexList.tsx | Add file-level oxlint suppression and @ts-expect-error |
| plugins/@sanity/embeddings-index-ui/src/embeddingsIndexDashboard/IndexInfo.tsx | Add file-level oxlint suppression and @ts-expect-error |
| plugins/@sanity/embeddings-index-ui/src/embeddingsIndexDashboard/IndexFormInput.tsx | Add file-level oxlint suppression and @ts-expect-error |
| plugins/@sanity/embeddings-index-ui/src/embeddingsIndexDashboard/IndexEditor.tsx | Add file-level oxlint suppression and @ts-expect-error; remove eslint-disable |
| plugins/@sanity/embeddings-index-ui/src/embeddingsIndexDashboard/hooks.ts | Add @ts-expect-error; remove eslint-disable-next-line |
| plugins/@sanity/embeddings-index-ui/src/embeddingsIndexDashboard/EmbeddingsIndexTool.tsx | Add file-level oxlint suppression and @ts-expect-error; remove eslint-disable |
| plugins/@sanity/embeddings-index-ui/src/embeddingsIndexDashboard/dashboardPlugin.ts | Add @ts-expect-error for legacy type import |
| plugins/@sanity/embeddings-index-ui/src/api/isEnabled.tsx | Add file-level oxlint suppression and @ts-expect-error |
| plugins/@sanity/embeddings-index-ui/src/api/embeddingsApiHooks.ts | Add @ts-expect-error for legacy client typing |
| plugins/@sanity/embeddings-index-ui/src/api/embeddingsApi.ts | Add @ts-expect-error for legacy client typing |
| packages/@sanity/plugin-kit/src/util/ts.ts | Add file-level oxlint suppression for unbound-method |
| packages/@sanity/plugin-kit/src/util/readme.ts | Add file-level oxlint suppression for unsafe type assertion |
| packages/@sanity/plugin-kit/src/util/log.ts | Add file-level oxlint suppression for console usage |
| packages/@sanity/plugin-kit/src/util/load-package-config.ts | Add file-level oxlint suppression for unsafe type assertion |
| packages/@sanity/plugin-kit/src/util/files.ts | Add file-level oxlint suppressions for multiple legacy rules |
| packages/@sanity/plugin-kit/src/sanity/manifest.ts | Add file-level oxlint suppressions for legacy loops/error handling |
| packages/@sanity/plugin-kit/src/presets/ui-workshop.ts | Add file-level oxlint suppressions for spread-related rules |
| packages/@sanity/plugin-kit/src/presets/semver-workflow.ts | Add file-level oxlint suppressions for spread/unsafe assertions |
| packages/@sanity/plugin-kit/src/presets/presets.ts | Add file-level oxlint suppression for await-in-loop |
| packages/@sanity/plugin-kit/src/npm/package.ts | Add file-level oxlint suppressions for multiple legacy rules |
| packages/@sanity/plugin-kit/src/dependencies/import-linter.ts | Add file-level oxlint suppression for map-spread |
| packages/@sanity/plugin-kit/src/cli.ts | Add file-level oxlint suppression for unsafe type assertion |
| packages/@sanity/plugin-kit/src/actions/verify/validations.ts | Add file-level oxlint suppressions for legacy loops/unsafe assertions |
| packages/@sanity/plugin-kit/src/actions/inject.ts | Add file-level oxlint suppressions for multiple legacy rules |
| AGENTS.md | Document preferred inline oxlint suppression patterns |
| .oxlintrc.json | Remove overrides and broad ignores now replaced by inline suppressions |
| .changeset/cute-coats-hang.md | Add an “empty” changeset entry describing the maintenance change |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+4
| --- | ||
| --- | ||
|
|
||
| Move oxlint suppressions from config to inline comments |
Resolve conflicts by keeping main's oxlint.config.ts migration and deep @sanity/icons imports, accepting deleted files, and re-applying inline oxlint suppressions. Strip package-wide plugin overrides from the new root oxlint config in favor of inline suppressions. Co-authored-by: Cody Olsen <stipsan@users.noreply.github.com>
✅ E2E Tests🟢 12 passed • view full report • view run Studio: https://plugins-e2e-test-studio-t1vy76umu.sanity.dev Datasets: |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| @@ -1,3 +1,4 @@ | |||
| // oxlint-disable eslint/no-console, typescript/no-unsafe-type-assertion - legacy code will be lint-cleaned in a follow-up PR | |||
There was a problem hiding this comment.
Duplicate turbo generator suppressions
Medium Severity
turbo/generators/src/config.ts now has an inline oxlint-disable for eslint/no-console and typescript/no-unsafe-type-assertion, while oxlint.config.ts still turns those same rules off for turbo/generators/**/*.ts. With reportUnusedDisableDirectives set to error, those comments become unused and can fail lint.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit c1f916d. Configure here.
Prune unused disable directives revealed by main's icon/API changes, and add inline suppressions for diagnostics previously covered by package-wide overrides in oxlint.config.ts.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 216 out of 217 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
plugins/sanity-plugin-mux-input/src/components/documentPreview/PaneItemPreview.tsx:6
- This file disables
eslint/no-restricted-importsbecause it imports fromlodash, but the shared oxlint config bans lodash imports in favor oflodash-esper-module imports. Switching tolodash-es/isNumber.jsandlodash-es/isString.jsshould let you remove theeslint/no-restricted-importssuppression while keeping behavior the same.
plugins/sanity-plugin-mux-input/src/util/createSearchFilter.ts:4 - This file disables
eslint/no-restricted-importsto allow alodashimport, but the repo lint config explicitly asks forlodash-esmodule imports instead. Switching tolodash-es/*lets you drop the suppression and keeps the file aligned with the monorepo’s dependency conventions.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 84ed0e4. Configure here.
| @@ -1,3 +1,4 @@ | |||
| // oxlint-disable typescript/no-unsafe-type-assertion - legacy code will be lint-cleaned in a follow-up PR | |||
There was a problem hiding this comment.
Lost intermittent assertion suppression
Medium Severity
The removed media package override turned off no-unnecessary-type-assertion because the assertions in zodFormResolver are only flagged as unnecessary for some dependency-hoisting graphs. The new file-level disable covers no-unsafe-type-assertion but not that rule, so a lockfile or hoisting change can make pnpm lint fail intermittently on this file.
Reviewed by Cursor Bugbot for commit 84ed0e4. Configure here.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 216 out of 217 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
plugins/sanity-plugin-mux-input/src/components/documentPreview/PaneItemPreview.tsx:5
- This file-level
eslint/no-restricted-importssuppression looks like it is only needed for thelodashimport. To keep the suppression as narrow as possible (and align with the documentedlodash-esconvention in AGENTS.md:435), consider scopingeslint/no-restricted-importsto the single import line instead of disabling it for the whole file.
plugins/sanity-plugin-mux-input/src/util/createSearchFilter.ts:4 - This file disables
eslint/no-restricted-importsfor the whole file, but the only restricted import appears to belodash. SinceAGENTS.mddocuments a repo convention to preferlodash-es(AGENTS.md:435), it would be better to either switch tolodash-es(would also require updatingpackage.json) or at least scope the suppression to just thelodashimport line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes package-wide oxlint ignore/override silencing for plugin source in favor of local inline suppressions, and documents the preferred suppression style in
AGENTS.md.Merge conflict resolution
Merged latest
origin/main(includes migration from.oxlintrc.json→oxlint.config.ts).Simple conflicts resolved:
.oxlintrc.jsonand retargeted this PR atoxlint.config.ts(kept only workspacee2e/turbo/generatorsoverrides; removed package-wide plugin overrides).@sanity/icons/*imports and other code, re-applied HEAD’soxlint-disablecomments.AGENTS.mdlint docs: main’s shared-config notes + this PR’s Lint Suppressions guidance (updated to referenceoxlint.config.ts).Complicated conflicts: none.
Verification
pnpm format✅pnpm lint✅pnpm build✅pnpm test run✅ (193 files / 1159 tests)