Skip to content

Y25-682 - Add RNAseq Workflow Branch#2700

Merged
sabrine33 merged 8 commits intoTriomic_Epicfrom
Y25-682
Mar 17, 2026
Merged

Y25-682 - Add RNAseq Workflow Branch#2700
sabrine33 merged 8 commits intoTriomic_Epicfrom
Y25-682

Conversation

@sabrine33
Copy link
Copy Markdown
Contributor

@sabrine33 sabrine33 commented Feb 9, 2026

@sabrine33 sabrine33 linked an issue Feb 9, 2026 that may be closed by this pull request
5 tasks
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 9, 2026

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.97%. Comparing base (5e55f23) to head (7dafc07).
⚠️ Report is 128 commits behind head on Triomic_Epic.

Files with missing lines Patch % Lines
...els/concerns/presenters/statemachine/permissive.rb 80.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           Triomic_Epic    #2700      +/-   ##
================================================
+ Coverage         84.59%   84.97%   +0.38%     
================================================
  Files               501      504       +3     
  Lines             20538    20779     +241     
  Branches            377      377              
================================================
+ Hits              17374    17657     +283     
+ Misses             3161     3119      -42     
  Partials              3        3              
Flag Coverage Δ
javascript 80.18% <ø> (+0.46%) ⬆️
pull_request 84.92% <90.90%> (+0.32%) ⬆️
push 84.59% <90.90%> (-0.01%) ⬇️
ruby 92.61% <90.90%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sabrine33 sabrine33 changed the base branch from develop to Triomic_Epic March 5, 2026 11:17
Copy link
Copy Markdown
Member

@yoldas yoldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few comments. Happy to discuss.

Comment thread config/pipelines/high_throughput_lcm_triomics.yml
Comment thread config/pipelines/high_throughput_lcm_triomics.yml
Comment thread config/pipelines/high_throughput_lcm_triomics.yml Outdated
Comment thread config/purposes/lcm_triomics_rna.wip.yml
Comment thread config/robots.rb Outdated
Comment thread config/robots.rb
Comment thread config/robots.rb Outdated
Comment thread config/robots.rb
@sabrine33 sabrine33 requested review from KatyTaylor and yoldas March 9, 2026 12:40
Comment thread config/pipelines/high_throughput_lcm_triomics.yml
Comment thread config/robots.rb Outdated
Comment thread config/robots.rb Outdated
Comment thread config/robots.rb Outdated
Comment thread app/models/concerns/presenters/statemachine/permissive.rb
Copy link
Copy Markdown
Collaborator

@KatyTaylor KatyTaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good I think, just one more question added. Going to look at the Integration Suite PR next.

LCMT RNA OdT Beads: LCMT RNA Denat/Hyb
LCMT RNA Denat/Hyb: LCMT RNA RT
LCMT RNA RT: LCMT RNA Preamp
LCMT RNA Preamp: LCMT cDNA Reserve
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please check this scenario?

Run the step-2 path, i.e., continue from LCMT RNA Preamp to LCMT cDNA Frag/ER
Do the charge and pass at LCMT cDNA Lib PCR XP.
Go back and continue from LCMT RNA Preamp to LCMT cDNA Reserve
(because LCMT cDNA Reserve was pre-created, continue with transfer)

We have a suspicion that because the same request is used for both branches, it may break.

include DoesNotAllowLibraryPassing
end

state :processed do
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also unsure why you need this new 'processed' state when there are already 4 of them. Can't you use one of the existing ones?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also unsure why you need this new 'processed' state when there are already 4 of them. Can't you use one of the existing ones?

Yes I checked, but you need to go through them to get to passed state

@sabrine33 sabrine33 merged commit d844c3e into Triomic_Epic Mar 17, 2026
16 checks passed
@sabrine33 sabrine33 deleted the Y25-682 branch March 17, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Y25-682 - Add RNAseq Workflow Branch

4 participants