fix(win): tests run on native Windows + diagnosable probe → 1.29.1 (#43) - #114
Merged
Conversation
gh's CI logs truncate the node --test output (~12KB, no TAP), so the real Windows test failures aren't readable. Tee npm test to win-tests.log (pipefail + continue-on-error) and upload it as an artifact — so the specific runtime blockers become diagnosable to fix verify-driven. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The test script set env via POSIX inline vars (KIT_NON_INTERACTIVE=1 … node) — Windows cmd/pwsh parse that as a command → 'not recognized', tests never start (found via the windows probe artifact). Replace with scripts/test.mjs: sets env in-process, collects dist/**/*.test.js itself (no shell-glob), runs node --test. No new dep (avoided cross-env — single-maintainer per kit triage). macOS verified (144 files, suite runs). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
A literal '/dev/null' becomes 'D:\dev\null' on Windows → ENOENT (7 test failures in the windows probe). os.devNull is the cross-platform null device. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
… probe diagnostics) (#43) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
✅ Docker image built successfully
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verify-driven #43 progress using the windows-latest probe.
Fixes (cross-platform, no new deps):
scripts/test.mjs— no-dep test runner (sets env in-process + collectsdist/**/*.test.jsitself). The oldtestscript's POSIX inline env-vars (KIT_NON_INTERACTIVE=1 … node) failed on Windows cmd/pwsh, so the suite never started.secrets-sync: literal/dev/null→os.devNull(wasD:\dev\nullENOENT — 7 failures).pipefail+continue-on-error) — gh's CI logs truncate it.Real windows-latest result now: Install ✓, Build ✓, 1526/1542 unit tests pass (up from: tests couldn't even start → then 1519 → 1526). The remaining 15 failures are characterized on #43: POSIX-path /
startsWith("/")test assumptions + chmod/0o600permission semantics (needs a Windows-ACL decision).macOS verified (144 test files, suite runs); avoided
cross-env(single-maintainer per kit triage) in favor of the node script.🤖 Generated with Claude Code