build(win): cross-platform build script + windows-latest probe CI (#43) → 1.28.2 - #111
Merged
Conversation
build/build:prod used POSIX rm -rf + chmod +x (fail on native Windows). Now rimraf (already a dep) + scripts/chmod-cli.mjs (no-op on win32) — same POSIX output (dist/cli.js stays 0755, verified). Adds a non-required windows-latest probe workflow (manual + windows-ci/** branches, SHA-pinned actions) so the remaining #43 blockers surface against a real Windows runner. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
rimraf is only a transitive dep — no node_modules/.bin/rimraf in a clean npm ci, so the bare `rimraf dist` broke the build in CI. Replace with scripts/clean-dist.mjs (node built-in fs.rmSync), fully self-contained + cross-platform. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ist/chmod-cli are present npm run build now runs node scripts/clean-dist.mjs + chmod-cli.mjs; the image must include scripts/ or the in-container build fails. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
✅ Docker image built successfully
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incremental #43 (native Windows), the verify-driven way.
build/build:prodused POSIXrm -rf dist+chmod +x dist/cli.js— both fail on native Windows. Nowrimraf(already a dep) +scripts/chmod-cli.mjs(no-ops on win32). Same POSIX output (verified:dist/cli.jsstays0755). kit can now build on Windows.windows-latestprobe CI. Non-required workflow (workflow_dispatch+windows-ci/**branches — NOT on every PR, no noise) that builds + unit-tests on a real Windows runner and smoke-runskit check(non-blocking). This surfaces the remaining Native Windows support (PowerShell/cmd) — tracking #43 blockers (POSIX git hooks,tar, secret-file ACLs) against a genuine Windows env instead of guessing on macOS. Actions SHA-pinned (passeskit gha-audit; my workflow is absent from the unpinned list).After merge I'll trigger the probe to capture the real Windows failures and iterate.
🤖 Generated with Claude Code