Removing an agent from a room does not stop message delivery - #412
Open
jameshoweee wants to merge 1 commit into
Open
jameshoweee wants to merge 1 commit into
jameshoweee wants to merge 1 commit into
Conversation
Removing an agent from a room deletes the membership row, but a running client holds its own per-room subscription and keeps receiving everything said in the room. Matrix used to enforce the kick at the homeserver, and that enforcement went away with it. Same leak on the pull side: poll_events returns everything buffered for the agent with no membership check, unlike its sibling poll_room_events. A removal is now rung over the invite bus the same way an invitation is, and the transport drops the room's subscription and its cursor. poll_events filters by the rooms the agent is in.
jameshoweee
requested review from
amaudruz and
christian-mcdermott
as code owners
September 9, 2026 11:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing an agent from a room deletes the membership row, but a running client holds its own per-room subscription and keeps receiving everything said in the room. Matrix used to enforce the kick at the homeserver, and that enforcement went away with it.
Same leak on the pull side:
poll_eventsreturns everything buffered for the agent with no membership check, unlike its siblingpoll_room_events.Fix: a removal is rung over the invite bus the same way an invitation is, and the transport drops the room's subscription and its cursor.
poll_eventsfilters by the rooms the agent is in.Tests fail before the change and pass after.