Repository navigation
Polish Blaxel soft debt from third-pass review - #48
Merged
Merged
Conversation
Drop unused create-plan options, project TS runtime state at the native boundary, map bare HTTP 409 to AlreadyExists, clarify Go Stat ownership, and update provider/user docs to match. Co-authored-by: Nabhag Motivaras <Nabhag8848@users.noreply.github.com>
6 tasks done
Member
Author
|
@cursoragent explian with examples so we can also document this. |
|
You need to increase your spend limit or enable usage-based billing to run background agents. Go to Cursor |
Scope bare 409 AlreadyExists to create, return real delete state with wait polling, and close Go/TS gaps that broke kind- and field-based app code. Co-authored-by: Cursor <cursoragent@cursor.com>
Drop wait polling; a successful DELETE is reported as Deleted even when Blaxel finishes removal asynchronously. Co-authored-by: Cursor <cursoragent@cursor.com>
Drop the 60s completion-hold policy for one native process wait, and report file Stat from a single ls path without parent listing. Co-authored-by: Cursor <cursoragent@cursor.com>
Drop builder-facing wording across guides, examples, and provider READMEs, and have TypeScript Stat use filesystem GET so file metadata matches Go. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the third-pass review on #44: clear the remaining soft-debt items and keep docs current.
BlaxelCreatePlan.options; create callsnative.create(params)only (still does not forward@blaxel/coreSandboxCreateOptions/ native 1–50s create timeout).@blaxel/coretypesSandboxInstance.sandboxprivate;projectHandlecopies wire runtime state onto a Kit-facingstateat the native boundary so identity mapping never reaches into the private field.AlreadyExistsin Go + TS; codedSANDBOX_DELETION_IN_PROGRESSstillConflict.Stat: comment clarifies why GET uses a rebuilt lower FS client (LSalwaysAsDirectory; no public Get/Stat onSandboxInstanceFSService).docs/*, and website Blaxel / lifecycle / errors / filesystem panes updated to match.Test plan
GOWORK=off go test .insdks/go/providers/blaxelnpm test -w @sandbox-kit/blaxel(68 tests)