Repository navigation
Fix Blaxel Ready conflation and unproven floors - #46
Merged
Merged
Conversation
Reject WaitCondition.Ready in TS (sandbox.wait is a deprecated no-op), map provisioning.timeout only as Blaxel create timeout, drop the undocumented 256 MiB memory floor, pre-reject reserved ports, align SANDBOX_ALREADY_EXISTS to AlreadyExists, and document global settings. Co-authored-by: Nabhag Motivaras <Nabhag8848@users.noreply.github.com>
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the second Blaxel review on #44. Implements the recommended leans (1A / 2A / 3A) plus the Ready fix.
Changes
WaitCondition.Ready: reject as unsupported (match Go).@blaxel/coresandbox.wait()is a deprecated no-op; Ready previously also forced a destructive create timeout.options.timeout(1–50s) when set under Default/Scheduled wait only.SANDBOX_ALREADY_EXISTS→AlreadyExists; Stat dual-path comment; TS README notes process-globalsettings.Not in this PR
ForProvidermatrixTest plan
GOWORK=off go test ./...insdks/go/providers/blaxelnpm test/npm run buildfor@sandbox-kit/blaxel