Protect against out of bounds ref id in cram_put_bam_seq. - #2087
Open
jkbonfield wants to merge 1 commit into
Open
Protect against out of bounds ref id in cram_put_bam_seq.#2087jkbonfield wants to merge 1 commit into
jkbonfield wants to merge 1 commit into
Conversation
By directly calling the API we can supply broken data leading to a four-byte heap out-of-bounds read-modify-write. However this is an API fix rather than a data-driven security bug as existing ways of providing a bam_seq_t are based on reading from files, which already have data validation. (Samtools reheader and samtools cat can change headers, but they both do raw read/write calls for speed. (Commit message written by James Bonfield)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By directly calling the API we can supply broken data leading to a four-byte heap out-of-bounds read-modify-write.
However this is an API fix rather than a data-driven security bug as existing ways of providing a bam_seq_t are based on reading from files, which already have data validation.
(Samtools reheader and samtools cat can change headers, but they both do raw read/write calls for speed.
(Commit message written by James Bonfield)