Repository navigation
feat(config): replace prefetch.mode with prefetch.enabled (#340) - #341
Merged
Merged
Conversation
prefetch.enabled is now the only switch. Of prefetch.mode's values, aggressive and opportunistic behaved the same (should_prefetch_now returned true for both), and disabled switched prefetch off by a second route, a coordinator that ran and planned nothing. The mode is retired, and with it PrefetchMode, StrategyMode, the status mode field and PerformanceCalibration::recommended_strategy. A config that switched prefetch off keeps it off. FOLDED_VALUES moves a retired key's value to a current key: the parser reads mode = disabled as enabled = false after every section, so line order does not matter and an explicit enabled = false is never turned back on. Any other mode value is ignored, never refused. config upgrade writes the fold before the line goes and names it, and the 0.4.x rollback copy carries the same enabled value, which 0.4.x honours. Closes #340
- Credit to dlicudi for macOS port of XEarthLayer - Credit to NASA for useage of Blackmarble VIIRS data - Added summary of Package Manager and screenshot - Fixed and updated screenshot of XEarthLayer dashboard TUI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #340
Change
prefetch.enabled(defaulttrue) is the only prefetch switch, along withrun --no-prefetch.prefetch.modeis retired.aggressiveandopportunisticbehaved identically, becauseshould_prefetch_nowreturnedtruefor both.disabledduplicatedenabled = false.PrefetchMode,StrategyMode,CoordinatorStatus::modeandPerformanceCalibration::recommended_strategy.FOLDED_VALUESinconfig/upgrade.rsmoves a retired key's value to a current key. The parser applies folds after every section is read.config upgradewrites the result and names it, and the startup notice counts a leftovermodeline as one deprecated setting.enabledis the oldenabledANDmode != disabled. Any other mode value is ignored, never refused.modeline. It doesn't need to. 0.4.8 honoursprefetch.enabled, and with nomodeline it falls back toauto, which runs as opportunistic. This was checked against the v0.4.8 tag.docs/configuration.md, the README, the prefetch design docs, CLAUDE.md and the CHANGELOG.Verification
make pre-commitpasses.config upgradeand its dry run, the startup notice count, and the 0.4.x rollback copy.config upgradeon a scratch HOME turnedmode = disabledintoenabled = falseand removed themodeline. Afterwards,config get prefetch.enabledreturnsfalse.