Repository navigation
feat(packages): a Settings tab for the [packages] settings (#336) - #339
Merged
Merged
Conversation
The package manager gains a fourth tab listing every [packages] setting of config.ini, with its value or its default, and the setting's help beside it. Enter edits and Enter again saves, after the same validation `xearthlayer config set` applies; Esc cancels and flags flip with Space or the arrows. A saved value reaches the next queue, and a new library URL or install location reloads its tab. The tab is read-only while `run` is active or any job is unfinished. The help text moves to config::help, the one source for the tab and for the comments config.ini is created with. ConfigFile::save_to now writes atomically, so an interrupted save cannot truncate config.ini. Closes #336
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #336
Change
[packages]settings ofconfig.ini. Each row shows the value, or the default when the setting is unset, with that setting's help beside it.xearthlayer config setruns. Esc cancels, and true/false settings flip with Space or the arrow keys.xearthlayer runis active or any job is queued or running.config::help, which feeds both the tab and theconfig.inicomments. The comments are rewrapped to 80 columns.ConfigFile::save_tonow writes atomically, so an interrupted save cannot truncateconfig.ini.Verification
make pre-commitpasses.concurrent_downloadssaved as 3,auto_install_overlaysflipped to true, and the invalid value 0 was refused with the file left unchanged.