Repository navigation
feat(config): read the v2 library generation, and move old library URLs to it - #338
Merged
Merged
Conversation
…Ls to it (#334) From beta.1 the client reads library generation v2, the rebuilt world. Changing the default alone would move nobody: 0.4.8 wrote library_url into every config file it created. - DEFAULT_LIBRARY_URL is https://xearthlayer.app/packages/v2/xearthlayer_package_library.txt. - The pre-0.5 root URL (LEGACY_LIBRARY_URL) and the alpha staging URL (ALPHA_STAGING_LIBRARY_URL) are retired values for packages.library_url, read by the parser as the v2 URL, as prefetch.mode = auto is read as opportunistic. Every reader gets v2 at once; the startup notice and config upgrade rewrite the file. - The first-start layout migration saves the v2 URL into the new config and says so. The legacy copy of the config, kept for a rollback to 0.4.x, was re-saved from the parsed config and so would have pointed 0.4.x at the v2 world; it now keeps the URL it had. A library URL of one's own is left alone. Verified in a scratch HOME: a 0.4.8-style ~/.xearthlayer/config.ini naming the old URL migrates with "packages.library_url now reads the rebuilt scenery library", the new config holds the v2 URL and the legacy copy the old one; a migrated config naming the alpha staging URL reads v2, and config upgrade backs it up and rewrites it. Closes #334
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From beta.1 the client reads library generation v2. Changing the default alone would move nobody: 0.4.8 wrote
library_urlinto every config file it created.DEFAULT_LIBRARY_URLishttps://xearthlayer.app/packages/v2/xearthlayer_package_library.txt.packages.library_url: the parser reads them as the v2 URL, and the startup notice andconfig upgraderewrite the file.Do not merge before #335:
v2/is not on xearthlayer.app until the promotion, so a build from develop could not fetch the library until then.Verification
config upgraderewrites them; the migration writes v2 to the new config, keeps the old URL in the legacy copy, and names the change.~/.xearthlayer/config.iniwith the old URL migrates with "packages.library_url now reads the rebuilt scenery library"; a migrated config naming the alpha staging URL reads v2, andconfig upgradebacks it up and rewrites it.Closes #334