test: give every dialect directive a case and a verdict - #784
Merged
Merged
Conversation
The sheet tw prints for a scanned project was assembled inside the CLI, so the sweep measuring that sheet against Tailwind rebuilt only half of it: the utilities from an empty class list and the splice, never the classes a project's own declarations route. A case whose markup carries a class could not be measured. Tw_tools.Project.stylesheet is that assembly now, and the CLI calls it; what it prints is unchanged byte for byte.
The sweep was written from the bugs already found, and it stayed green while more were reported in idioms it did not contain: a list its author wrote can only hold what its author already knew. The inventory comes from the oracle now. Every at-keyword the pinned bundle handles beyond CSS's own, and every value function it defines, must have a case, so one nobody thought to cover, or one a Tailwind upgrade adds, fails here. A case declares parity or a divergence with its reason, and a divergence that starts matching fails as well, so a gap that gets fixed reports itself. Cases compile through Tw_tools.Project, which lets them carry markup classes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dialect sweep was a hand-written idiom list, so it stayed green while defects were reported in idioms it did not contain. Its inventory now comes from Tailwind's bundle, each case declares parity or a measured divergence, and it compiles through
Tw_tools.Project, the CLI's project pipeline moved out ofbin/main.ml.