modifiers: sort peer- by the variant it wraps, like group- - #773
Merged
Conversation
samoht
added this pull request to stack #728
September 13, 2026 19:53
The seed a run prints has to replay on its own. Sharing one state couples every drawer, so what the fuzzer sees depends on how much randomness ran before it: the seed that failed CI passed when the sort tests were run alone, and a real ordering defect read as a flake for a session. rng_named seeds a state from the run's seed and the test's own name, so the sequence is the same whatever else runs. The ordering test it found fails on the parent commit.
peer-hover was special-cased into group-hover's slot, which pulled it out of the peer group and in front of every other peer- spelling. Tailwind writes peer-checked, then peer-hover, then peer-focus - the inner variant order, which is what the general peer- rule already gives. The same line named group-hover, where it was redundant: the general group- rule sends it to the same slot.
samoht
force-pushed
the
peer-hover-slot
branch
from
September 13, 2026 20:14
cfe02f7 to
6203d27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
peer-hoverwas special-cased intogroup-hover's slot, which pulled it out of the peer group and in front of every otherpeer-spelling. Tailwind writespeer-checked, thenpeer-hover, thenpeer-focus.This is the failure that has been reading as a flaky
sorttest. It is real and it is deterministic; it only looked intermittent because the seed a run prints could not replay it.03d50aafixes that separately: one shared RNG coupled every drawer, so the seed that failed CI passed when the sort tests were run alone. Follows #772.