test: hold the colour families to whole declarations - #754
Merged
Merged
Conversation
samoht
added this pull request to stack #728
September 13, 2026 16:08
Most of these pinned a value without saying which property it landed on, so a utility writing the right colour into the wrong longhand passed. The two negative checks were weaker still: "no color-mix in text-blue-600/100" and "the default palette is not resolved" both pass on a sheet with no rule in it at all.
samoht
force-pushed
the
exact-color-assertions
branch
from
September 13, 2026 19:26
5254128 to
9364273
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most assertions here pinned a value without saying which property it landed on, so a utility writing the right colour into the wrong longhand passed. The two negative checks were weaker still: both pass on a sheet with no rule in it.