test: say what the ordering oracle checks, and what it cannot - #744
Merged
Merged
Conversation
samoht
added this pull request to stack #728
September 13, 2026 14:24
check_ordering_matches runs the canonical differ, which suppresses every reorder it can prove cascade-neutral: two rules reorder observably only where they overlap in both dimensions, which is the pairing interacting_pairs finds. A family emitted in the wrong band therefore passes whenever nothing in the band between contends with it. Its doc claimed it compares the ordering of utilities and fails when they differ. test/parity/sheet_order.ml already says otherwise, so the two files contradicted each other, and twenty-seven suites call this under names ending "suborder matches Tailwind". The assertion is worth keeping: it catches a wrong value, a dropped or surplus declaration, a missing rule, and a reorder that can change the cascade. Only the ordering half of the name was unearned. check_class_order reads positions back for the classes it is given, and sheet_order_gap is the whole-sheet answer.
samoht
force-pushed
the
harness-ordering-claim
branch
from
September 13, 2026 19:26
bd594e0 to
0823839
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_ordering_matchesruns the canonical differ, which suppresses every reorder it can prove cascade-neutral — two rules reorder observably only where they overlap in both dimensions, the pairinginteracting_pairsfinds. A family emitted in the wrong band passes whenever nothing in the band between contends with it.Its doc claimed it "compares the ordering of utilities… failing if they differ".
test/parity/sheet_order.mlalready says otherwise, so the two files contradicted each other, and twenty-seven suites call this under names ending "suborder matches Tailwind".The assertion is worth keeping — it catches a wrong value, a dropped or surplus declaration, a missing rule, and a reorder that can change the cascade. Only the ordering half of the name was unearned.
check_class_orderreads positions back for the classes it is given;sheet_order_gapis the whole-sheet answer.