fuzz: compare lists with an element equality - #293
Merged
Merged
Conversation
The polymorphic <> walked a Supports.t list past its abstraction, and the pre-commit hook stopped on all seven sites.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seven polymorphic list comparisons in the fuzz suite tripped merlint E106, which blocks the pre-commit hook on any commit to the tree. Six compare lists of scalars and were only unidiomatic; fuzz_context.ml's supports check compared a Supports.t list, walking an abstract type from another module past its abstraction - that one now calls Supports.equal, which the module already exports. No behaviour change: same assertions, same failures.