Skip to content

Fix projectile collision crash: defer free and disable monitoring on … #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samjhill merged 1 commit into from
Aug 9, 2025
Merged

Fix projectile collision crash: defer free and disable monitoring on … #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions scripts/core/laser_projectile.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,17 @@ func _physics_process(delta):
position += direction.normalized() * speed * delta

func _on_body_entered(body):
if not is_instance_valid(body):
if not is_instance_valid(body) or body == self:
return

if body.has_method("take_damage"):
body.take_damage(damage)
queue_free() # Destroy the laser after hitting
# Disable further monitoring and free safely after signal emission
set_deferred("monitoring", false)
var shape = get_node_or_null("CollisionShape2D")
if shape:
shape.set_deferred("disabled", true)
call_deferred("queue_free")

func _on_Timer_timeout():
queue_free()
10 changes: 8 additions & 2 deletions scripts/core/projectile.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,15 @@ func _physics_process(delta):
position += direction * speed * delta

func _on_body_entered(body):
if not is_instance_valid(body):
if not is_instance_valid(body) or body == self:
return

# Only interact with valid damage receivers (e.g., enemies)
if body.has_method("take_damage"):
body.take_damage(damage)
queue_free()
# Disable further monitoring to prevent re-entrancy during signal emission
set_deferred("monitoring", false)
var shape = get_node_or_null("CollisionShape2D")
if shape:
shape.set_deferred("disabled", true)
call_deferred("queue_free")
Loading