Fix exponential macro expansion in const_max!#22
Open
mercnz wants to merge 1 commit intosamitbasu:mainfrom
Open
Fix exponential macro expansion in const_max!#22mercnz wants to merge 1 commit intosamitbasu:mainfrom
mercnz wants to merge 1 commit intosamitbasu:mainfrom
Conversation
twitzelbos
referenced
this pull request
in twitzelbos/rhdl
Apr 29, 2026
Closes the remaining Tier 1/2 gaps and ships the first eight Tier-3 protocol PHYs. Lib test count: 275 -> 346 (0 regressions). Tier 1/2 closeouts: - core::pwm: saw-tooth + comparator (Roadmap #22, treated as Tier-3 entry but trivially small) - core::comparator: unsigned wide comparator emitting all 5 flags in one call (Roadmap #10) - core::register_file: bus-agnostic N-register array, combinational read + registered write, foundation for all peripheral adapters (Roadmap #17) Tier 3 batch: - core::uart_tx: 8-N-1 transmitter with runtime divisor (#18 TX half) - core::uart_rx: 8-N-1 receiver with mid-baud sampling (#18 RX half) - core::spi_master: Mode 0, MSB-first, 4-wire (#19) - core::spi_slave: Mode 0, MSB-first, oversampled sclk_in (#20) - core::i2c_master: write-only single-byte v1 with open-drain outputs - first widget that exercises tristate end-to-end (#21) - core::ws2812: single-pixel WS2812/SK6812 driver (#26) - core::dht22: 40-bit humidity/temperature single-wire sensor (#29) CHANGELOG updates document per-widget design decisions, surprises hit (or-patterns are forbidden in kernels; type inference for .as_bits() returns the outer kernel const generic; FSMs that "wait for line release" need an explicit two-step high-then-low wait), and per-widget follow-ups. CLAUDE.md and widget-roadmap.md updated; recommended-first-eight list and the strikethrough roadmap are both kept current. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
had severe memory bloating, like 48gb+ this dramatically reduced it for me.