RELEASE-20260511#204
Merged
Merged
Conversation
- Simplified the navigation push logic in the interview result page for better readability. - Improved client IP retrieval in server-side props for guest interview reports, adding a console log for debugging purposes. - Updated Nginx configuration to restore the actual client IP with appropriate settings for real IP handling.
- Added a console error log to capture and stringify errors occurring during the guest interview report process for better debugging.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a guest interview feature, allowing unauthenticated users to experience a limited demo of the AI mock interview service. Key changes include updating middleware to allow public access to interview routes, implementing guest-specific API endpoints, and adding UI components such as the GuestInterviewModal and demo-specific banners. The PR also refactors the CreateInterviewForm and RankCard for improved UX, integrates Google AdSense, and restricts result visibility for guest users. Feedback focuses on improving error handling in the guest API, removing sensitive IP logging from production code, and utilizing the newly created GoogleAdSenseComponent to reduce code duplication.
| .catch((error) => { | ||
| if (isAxiosError(error)) { | ||
| if (error.response?.status === 400) { | ||
| throw new Error(error.response.data.message); |
Contributor
There was a problem hiding this comment.
error.response.data가 존재하지 않거나 message 필드가 없을 경우 런타임 에러가 발생할 수 있습니다. 옵셔널 체이닝을 사용하고, 기본 에러 메시지를 제공하여 안정성을 높이는 것이 좋습니다.
Suggested change
| throw new Error(error.response.data.message); | |
| throw new Error(error.response?.data?.message || "면접 생성 중 오류가 발생했습니다."); |
| (context.req.headers["x-real-ip"] as string) || | ||
| context.req.socket.remoteAddress || | ||
| ""; | ||
| console.log("clientIp for guest interview report", clientIp); |
Contributor
There was a problem hiding this comment.
운영 환경에서 클라이언트의 IP 정보를 로그로 남기는 것은 보안 및 개인정보 보호 측면에서 부적절할 수 있습니다. 디버깅용 로그라면 제거하는 것을 권장합니다.
| } | ||
| }; | ||
| } catch (error) { | ||
| console.error("error for guest interview report", JSON.stringify(error)); |
Contributor
There was a problem hiding this comment.
JSON.stringify(error)는 Error 객체의 정보를 제대로 출력하지 못하는 경우가 많습니다(빈 객체 {} 반환). 에러 객체 자체를 로그로 남기거나 error.message를 사용하는 것이 디버깅에 더 도움이 됩니다. 또한 운영 환경에서는 상세한 에러 로그 노출을 최소화해야 합니다.
Suggested change
| console.error("error for guest interview report", JSON.stringify(error)); | |
| console.error("error for guest interview report", error); |
Comment on lines
+22
to
+24
| import GuestInterviewModal from "@/domains/interview/components/guestInterviewModal"; | ||
| import { useModal } from "@kokomen/utils"; | ||
| import Image from "next/image"; |
Contributor
There was a problem hiding this comment.
GoogleAdSenseComponent를 사용하기 위해 임포트를 추가해야 합니다.
Suggested change
| import GuestInterviewModal from "@/domains/interview/components/guestInterviewModal"; | |
| import { useModal } from "@kokomen/utils"; | |
| import Image from "next/image"; | |
| import GuestInterviewModal from "@/domains/interview/components/guestInterviewModal"; | |
| import { useModal } from "@kokomen/utils"; | |
| import Image from "next/image"; | |
| import { GoogleAdSenseComponent } from "@/domains/ads/googleAdsenseComponent"; |
Comment on lines
+66
to
+73
| <ins | ||
| className="adsbygoogle" | ||
| style={{ display: "block" }} | ||
| data-ad-client="ca-pub-9998347148036420" | ||
| data-ad-slot="4601910391" | ||
| data-ad-format="auto" | ||
| data-full-width-responsive="true" | ||
| ></ins> |
Contributor
There was a problem hiding this comment.
이번 PR에서 추가된 GoogleAdSenseComponent를 사용하여 중복 코드를 제거하고 유지보수성을 높이는 것을 권장합니다. 해당 컴포넌트는 광고 초기화 로직(adsbygoogle.push({}))을 포함하고 있어 더 안정적으로 광고를 로드할 수 있습니다.
<GoogleAdSenseComponent />
🛠️ Build SummaryStatus: ✅ SUCCESS 📋 Build Output (마지막 45줄)🤖 Generated by GitHub Actions at Mon May 11 12:59:26 UTC 2026 |
🚀 Lighthouse Report for TEST1📅 Date: 5/11/2026
📊 Performance Details
🚀 Lighthouse Report for TEST2📅 Date: 5/11/2026
📊 Performance Details
🚀 Lighthouse Report for TEST3📅 Date: 5/11/2026
📊 Performance Details
🚀 Lighthouse Report for TEST4📅 Date: 5/11/2026
📊 Performance Details
🚀 Lighthouse Report for TEST5📅 Date: 5/11/2026
📊 Performance Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RELEASE-20260511