Conversation
Nardax
approved these changes
Nov 29, 2022
Nardax
left a comment
Nardax
left a comment
There was a problem hiding this comment.
structured logging is a nice improvement here.
|
|
||
| try | ||
| { | ||
| logger.LogTrace("UnlockInstance enter {host}: {redisKey}, {LockId}"); |
There was a problem hiding this comment.
Please fix placeholder casing. Microsoft recommends to use PascalCase - should be {Host}, {RedisKey} and {LockId}
|
|
||
| try | ||
| { | ||
| logger.LogTrace("UnlockInstanceAsync enter {host}: {redisKey}, {LockId}", |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
@samcook Hi Sam! Any chance to merge this PR? Realy need it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Structured logging is the practice of implementing a consistent, predetermined message format for application logs that allows them to be treated as data sets rather than text. The idea of structured logging is to take an application log that is delivered as a string of text and convert it into a simple relational data set that can be more easily searched and analyzed.
https://docs.microsoft.com/pt-br/aspnet/core/fundamentals/logging/?view=aspnetcore-6.0#log-message-template