Web design - #3
Merged
Merged
Conversation
- restyle GET / per docs/WEBDESIGN_PLAN.md rev2: warm sheet, light-blue ruled lines, red margin line; entries written on the rules, state marks in the margin column (the old print-shop card look is replaced) - self-hosted assets inlined at import: Patrick Hand woff2 as a base64 data-URI, Phosphor SVGs (app/static/icons) as one currentColor symbol sprite; page stays a single self-contained HTML string, no static mount - job status is now icon + exact API state word + pen color (graphite queued, ink-blue converting/scanning, cyan printing, green done, red failed, struck-through cancelled); emoji status strings removed - signature element: pencil writing a wavy ink line while a job works (prefers-reduced-motion shows a static drawn line) - new Jobs section: GET /jobs rendered with per-format glyphs, per-state margin marks and cancel (DELETE) buttons for active jobs; refreshed on load, on job events and every 5 s - new pins in tests/api/test_health_web.py: jobs list present, no emoji anywhere, assets inlined/self-hosted; all previously pinned hooks kept verbatim (345 tests pass, coverage 95.5%, ruff clean) - PRODUCT.md (product truth), DESIGN.md + .impeccable/design.json (the recorded visual system); .gitignore now covers downloads/ like uploads/
- scan lives at GET /scan (same ruled sheet, same parts); the print page keeps one always-visible drawn-box Scan nav button in the header, the scan page carries a Print nav button back; POST /scan and the scan polling/download logic are unchanged - page-aware JS: scan block runs only when #scanSection exists (so the print page keeps no scan code paths); window.startScan/pollScan exposed for the inline onclick; scan page degrades to "No scanner detected - the printer may be off or unplugged." until GET /scanners reports one - SCAN_PAGE assembled from the same CSS1-3 + body + JS1-3 parts as the print page; assets still inlined once each (font data-URI + sprite) - tests: root page now asserts the Scan hand-off + absence of scan UI; /scan asserts the form, options, back-nav and calm no-scanner degrade (349 tests, 95.5% coverage, ruff clean, detector []) - docs: WEBDESIGN_PLAN.md layout + as-built notes, DESIGN.md tokens (status/nav/small-hand type steps, focus radius) record both pages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Related issue
How was this tested?
Screenshots (if applicable)
Checklist