Fix cmd.script bg=True deleting tempfile before child runs - #69967
Open
twangboy wants to merge 2 commits into
Open
Fix cmd.script bg=True deleting tempfile before child runs#69967twangboy wants to merge 2 commits into
twangboy wants to merge 2 commits into
Conversation
Keep the script available for background PowerShell/cmd/POSIX runs via a self-cleaning wrapper, then remove it after exit. Refs saltstack#69959 saltstack#50273
Do not exec the real script from the /bin/sh wrapper; exec replaces the shell and skips the EXIT trap, leaving the tempfile behind. Refs saltstack#69959 saltstack#50273
twangboy
force-pushed
the
fix/69959/3006.x
branch
from
August 6, 2026 21:51
b7a1673 to
a96f671
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Keep the script available for background PowerShell/cmd/POSIX runs via a self-cleaning wrapper, then remove it after exit.
What issues does this PR fix or reference?
Fixes #69959
Fixes #50273
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes