Skip to content

Label y-axis units on stress-test CPU and inode panels #69965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
charzl wants to merge 3 commits into
base: 3008.x
Choose a base branch
from
Open

Label y-axis units on stress-test CPU and inode panels #69965

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba1a12d
Label y-axis units on stress-test CPU and inode panels
charzl Aug 4, 2026
f00f1e6
Revert unrelated .gitignore entry
charzl Aug 5, 2026
ab929b7
Disambiguate the "short"-unit y-axis label by panel title
charzl Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions tests/monitoring/render_panels.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,14 @@ def _bytes_unit(unit_hint: str) -> bool:
return unit_hint.lower() in ("bytes", "decbytes", "kbytes", "mbytes", "gbytes")


def _is_percentunit(unit_hint: str) -> bool:
return unit_hint.lower() == "percentunit"


def _is_count_unit(unit_hint: str) -> bool:
return unit_hint.lower() == "short"


def render_panel(panel: dict, end_ts: float) -> plt.Figure | None:
"""Return a matplotlib Figure for ``panel``, or ``None`` if no series."""
targets = panel.get("targets") or []
Expand All @@ -130,6 +138,8 @@ def render_panel(panel: dict, end_ts: float) -> plt.Figure | None:

unit_hint = panel.get("fieldConfig", {}).get("defaults", {}).get("unit") or ""
is_bytes = _bytes_unit(unit_hint)
is_percentunit = _is_percentunit(unit_hint)
is_count = _is_count_unit(unit_hint)

fig, ax = plt.subplots(figsize=(11, 4))
series_count = 0
Expand Down Expand Up @@ -165,6 +175,23 @@ def render_panel(panel: dict, end_ts: float) -> plt.Figure | None:
ax.set_title(panel.get("title") or "panel", fontsize=11)
if is_bytes:
ax.set_ylabel("MB")
elif is_percentunit:
# Grafana's percentunit is a 0-1 ratio (1.0 == 1 CPU core, not 1% of
# the host); rate(container_cpu_usage_seconds_total[...]) values here
# are already in that ratio, so label explicitly to avoid confusing
# "1.2" with "1.2% of the host" instead of 1.2 CPU cores.
ax.set_ylabel("CPU cores (1.0 = 1 core)")
elif is_count:
# "short" also covers FD/process counts (Master & API Resource Usage)
# alongside inode counts -- disambiguate from the panel title so the
# label says what's actually being counted, not just "count".
title = (panel.get("title") or "").lower()
if "inode" in title:
ax.set_ylabel("inodes used")
elif "fd" in title or "process" in title:
ax.set_ylabel("count (FDs vs processes)")
else:
ax.set_ylabel("count")
ax.xaxis.set_major_formatter(DateFormatter("%H:%M"))
ax.tick_params(axis="x", rotation=30, labelsize=8)
ax.tick_params(axis="y", labelsize=8)
Expand Down
Loading