Pass file.managed kws in x509.certificate_managed_wrapper - #69956
Open
lkubb wants to merge 3 commits into
Open
Conversation
twangboy
approved these changes
Aug 4, 2026
The previous test for file.managed args could not have succeeded, apparently it wasn't run in CI. bcrypt is only required for handling encrypted private keys, which were not tested in the ssh_pki.certificate_managed_wrapper tests so far.
twangboy
force-pushed
the
x509_v2-wrapper-file-args
branch
from
August 4, 2026 15:32
cb5124e to
0a238ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
file.managedare passed correctly.ssh_pkitest analog.ssh_pkitest requirements/adds one test there.What issues does this PR fix or reference?
Fixes: #69954
Previous Behavior
file.managedkwargs incertificate_managedwere swallowed byx509.certificate_managed_wrapper.New Behavior
file.managedkwargs are passed as expectedMerge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes