Skip to content

Fix mod_aggregate for pkg state module when a version is specified in a pkgs argument - #69737

Open
bdrx312 wants to merge 1 commit into
saltstack:3007.xfrom
bdrx312:fix_pkg_combine_pkgs
Open

Fix mod_aggregate for pkg state module when a version is specified in a pkgs argument#69737
bdrx312 wants to merge 1 commit into
saltstack:3007.xfrom
bdrx312:fix_pkg_combine_pkgs

Conversation

@bdrx312

@bdrx312 bdrx312 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

What issues does this PR fix or reference?

Fixes #69736

Previous Behavior

Raised an exception

New Behavior

Correctly aggregates the packages for multiple states even when a version is specified

Merge requirements satisfied?

Commits signed with GPG?

No

@bdrx312
bdrx312 requested a review from a team as a code owner July 7, 2026 05:16
@bdrx312
bdrx312 force-pushed the fix_pkg_combine_pkgs branch from a170c48 to 08ef176 Compare July 7, 2026 05:16
@bdrx312
bdrx312 force-pushed the fix_pkg_combine_pkgs branch from 08ef176 to 9600869 Compare July 7, 2026 12:32
@bdrx312
bdrx312 force-pushed the fix_pkg_combine_pkgs branch from 9600869 to ce2c5d3 Compare July 7, 2026 12:43
@dwoz dwoz added the test:full Run the full test suite label Jul 7, 2026
@dwoz
dwoz force-pushed the fix_pkg_combine_pkgs branch from ce2c5d3 to 4926147 Compare July 9, 2026 00:06
@dwoz dwoz added this to the Chlorine v3007.15 milestone Jul 9, 2026
@frebib

frebib commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

So fun fact- we tried running pkg aggregate at scale with a bunch of similar fixes here and found that states executed in the wrong order on occasion despite the requisites being correct. I'm not sure if it's something we did or a pre-existing bug, but there we go

@bdrx312

bdrx312 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

So fun fact- we tried running pkg aggregate at scale with a bunch of similar fixes here and found that states executed in the wrong order on occasion despite the requisites being correct. I'm not sure if it's something we did or a pre-existing bug, but there we go

@frebib I would love some more details about any issues you have experienced. I really would like to get the performance gains from this feature on my own projects. If you tag me on any issues you write or post in the discord, I can hopefully spend some time investigating.

Comment thread salt/states/pkg.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:full Run the full test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants