Fix #68915: Syndic reconnect after Master of Masters restart - #68923
Open
MuraveyApp wants to merge 2 commits into
Open
Fix #68915: Syndic reconnect after Master of Masters restart#68923MuraveyApp wants to merge 2 commits into
MuraveyApp wants to merge 2 commits into
Conversation
Contributor
|
Please remove the owlmind file. Needs a changelog and tests |
dwoz
force-pushed
the
fix/68915-syndic-reconnect
branch
from
June 26, 2026 13:18
30f188b to
9ad5eed
Compare
3 tasks
- Invalidate auth on pub_channel before close in Syndic.reconnect() so stale tokens are not reused on reconnection. - Start ZeroMQSocketMonitor on PublishClient.connect() with a reconnect_callback; on subsequent EVENT_CONNECTED events (after initial connection), the callback is scheduled via asyncio.ensure_future to trigger full re-authentication. - Add unit tests for ZeroMQSocketMonitor.monitor_callback reconnect behaviour and for Syndic.reconnect() auth invalidation. - Add changelog entry.
Regression test for saltstack#68915. Verifies that a syndic re-establishes its ZeroMQ connection to the Master of Masters after the MoM process is restarted, and that job dispatch to downstream minions through the syndic remains functional after the reconnect.
dwoz
force-pushed
the
fix/68915-syndic-reconnect
branch
from
July 4, 2026 01:24
9ad5eed to
6f9edc4
Compare
twangboy
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Generated by OwlMind