Fix import for WinRM version check

[lubinatien]

PyPI's package is named pywinrm.

The importlib.metadata.version("winrm") call raises PackageNotFoundError which isn't caught by except ImportError, crashing the block and leaving winrm undefined despite being importable.

What does this PR do?

What issues does this PR fix or reference?

Fixes salt-cloud with Windows minions using Winrm

Previous Behavior

salt-cloud crashes when using winrm to deploy windows minion.

New Behavior

salt-cloud deploys windows minion correctly.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

• Docs
• Changelog - https://docs.saltproject.io/en/master/topics/development/changelog.html
• Tests written/updated: Kind of:

% cat test.py
import salt.utils.versions

# Set the minimum version of PyWinrm.
WINRM_MIN_VER = "0.3.0"

try:
    import importlib
    import importlib.metadata

    # Verify WinRM 0.3.0 or greater

    version = importlib.metadata.version("winrm")
    if not salt.utils.versions.compare(version, ">=", WINRM_MIN_VER):
        HAS_WINRM = False
    else:
        HAS_WINRM = True

    import winrm
    from winrm.exceptions import WinRMTransportError

except ImportError:
    HAS_WINRM = False

print(HAS_WINRM)
% /opt/saltstack/salt/bin/python3.10 test.py
False
% sed -i 's/importlib\.metadata\.version("winrm")/importlib.metadata.version("pywinrm")/' test.py
% /opt/saltstack/salt/bin/python3.10 test.py
True

Commits signed with GPG?

Yes/No

[welcome]

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here's some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

• Salt's Contributor Guide
• Join our Community Discord
• Salt Project YouTube channel
• GitHub Discussions

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject.pdl@broadcom.com. We're glad you've joined our community and look forward to doing awesome things with you!

[twangboy]

Could we get a changelog and a test for this. Maybe just verify that "HAS_WINRM" is true.

[lubinatien]

Yes of course, I didn't include it as it's a partial rollback to what is was before:
1bb7749
I won't be able to do it now, but will provide you with a test before tomorrow!

[lubinatien]

Ok, hope this will be enough, I won't have time to create a proper test but updated the ticket with what I could.
Thanks a lot!

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.80%. Comparing base (0df82a0) to head (b4b8754).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           3006.x   #68768      +/-   ##
==========================================
- Coverage   60.80%   60.80%   -0.00%     
==========================================
  Files        3359     3359              
  Lines      461913   461913              
  Branches    95545    95545              
==========================================
- Hits       280810   280805       -5     
- Misses     155042   155049       +7     
+ Partials    26061    26059       -2     

Flag	Coverage Δ
salt	47.17% <100.00%> (-<0.01%)	⬇️
tests	82.78% <ø> (-<0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
salt/utils/cloud.py	25.73% <100.00%> (+0.20%)	⬆️

... and 16 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.