[3007.x] print minion output, mirror salt-ssh log level - #66952
Open
dead10ck wants to merge 2 commits into
Open
Conversation
salt-project-bot-prod-environment
Bot
changed the title
dead10ck
force-pushed
the
ssh/logging
branch
2 times, most recently
from
October 9, 2024 02:09
559901c to
d61cfc2
Compare
twangboy
requested changes
Oct 9, 2024
twangboy
left a comment
twangboy
left a comment
Contributor
There was a problem hiding this comment.
Could we get a test, please?
Contributor
|
Please rebase and fix conflicts |
twangboy
modified the milestones:
Chlorine v3007.12,
Chlorine v3007.13,
Chlorine v3007.14
- test_cmd_str_includes_log_level: verifies OPTIONS.log_level in the base64-encoded shim payload matches the master log_level - test_cmd_str_log_level_defaults_to_info: verifies default when unset - test_shim_cmd_passes_print_output_to_exec_cmd: propagation through Single.shim_cmd -> Shell.exec_cmd - test_cmd_block_passes_print_output_to_shim_cmd: propagation through Single.cmd_block -> shim_cmd - test_run_cmd_print_output_streams_stdout_stderr: Shell._run_cmd with print_output=True writes to sys.stdout/stderr - test_exec_cmd_passes_print_output_to_run_cmd: Shell.exec_cmd passes the flag through to _run_cmd
twangboy
approved these changes
Jul 8, 2026
Contributor
|
Please fix the failing tests and address the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
Fixes #66951
New Behavior
Minion logs are logged to stderr. Log level matches that of salt-ssh.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No