[master] This addresses the discovery of libcrypto on the latest OSX #66206
Open
ctrix wants to merge 1 commit into
Open
[master] This addresses the discovery of libcrypto on the latest OSX #66206ctrix wants to merge 1 commit into
ctrix wants to merge 1 commit into
Conversation
salt-project-bot-prod-environment
Bot
changed the title
Contributor
|
@ctrix Is there any logic to prefer the onedir package's library over homebrew's? |
Contributor
|
We should fix this on 3006.x branch instead of master |
twangboy
force-pushed
the
improve_libcrypto_path_discovery
branch
from
192b08f to
4db0c7d
Compare
twangboy
force-pushed
the
improve_libcrypto_path_discovery
branch
from
4db0c7d to
25881e7
Compare
Contributor
|
Please rebase. Needs changelog and a test. |
dwoz
force-pushed
the
improve_libcrypto_path_discovery
branch
from
25881e7 to
8713d4a
Compare
Contributor
|
@ctrix Is this still an issue? I thought I recalled merging another PR that addressed this recently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…atest brew.
What does this PR do?
On the latest darwin with homebrew salt-ssh doesn't work because (among all the issues) it doesn't find libcrypto.
What issues does this PR fix or reference?
Fixes: this allows proper discovery of libcrypto
Merge requirements satisfied?
Probably not.
Commits signed with GPG?
No