fix resolve local path dynamically from base_url#63
Merged
twangboy merged 1 commit intoApr 30, 2026
Conversation
twangboy
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #62
Summary
This PR removes the hardcoded repository path and dynamically resolves the local directory path based on
base_url.Problem
The script previously assumed a fixed path:
${generic_versions_tmpdir}/artifactory/saltproject-generic/onedir
This caused failures when using custom or non-standard repository paths.
Solution
Extract the URL path from
base_urland map it to the directory created by wget:url_path=$(printf '%s\n' "$base_url" | sed -E 's|^[a-zA-Z]+://[^/]+/?||')
url_path=${url_path%/}
local_path="${generic_versions_tmpdir}"
[ -n "$url_path" ] && local_path="${generic_versions_tmpdir}/${url_path}"
Changes
Behavior
Testing
Tested with:
Notes
This logic depends on wget directory structure. If wget flags change, path resolution may need adjustment.