Handle rc releases in the Windows Script#58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change updates how svtminion.ps1 discovers and ranks Salt onedir versions from the index at -Source. latest and major-series requests (for example 3006) now resolve only to GA CalVer directory names (digits and dots). Prerelease directories (names containing segments like rc or dev) are excluded from those aggregations but remain installable when -MinionVersion matches the exact directory name (for example 3008.0rc1).
Previous Behavior
The script was crashing with the new release of 3008.0rc1
New Behavior
RC releases are now only installable via exact version name. Latest and major install the latest available GA version or the latest available GA version for the major branch you specified.