Pass apt_conf context variables to the template as json object#68
Open
jerrykan wants to merge 1 commit intosaltstack-formulas:masterfrom
Open
Pass apt_conf context variables to the template as json object#68jerrykan wants to merge 1 commit intosaltstack-formulas:masterfrom
jerrykan wants to merge 1 commit intosaltstack-formulas:masterfrom
Conversation
5305a8f to
8f766d5
Compare
Previously when passing the apt_conf context variable to the template the variables would not necessarily retain their correct type. An example of this would be when using a pillar value of `null` it would be passed to the template as the string `"None"` instead of type `None`. If we pass the apt_conf context variables to the template using a json object the variables retain their correct types.
8f766d5 to
d553e46
Compare
baby-gnu
reviewed
Feb 10, 2021
Contributor
baby-gnu
left a comment
There was a problem hiding this comment.
Hello.
Do you think this fix could be tested?
It may require a little bit of work like:
- add an example in
pillar.example - create a new Inspec profile looking like the unattended one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]Changes related to the build system[chore]Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]Changes to the continuous integration configuration[feat]A new feature[fix]A bug fix[perf]A code change that improves performance[refactor]A code change that neither fixes a bug nor adds a feature[revert]A change used to revert a previous commit[style]Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]Documentation changes[test]Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE?No.
Related issues and/or pull requests
Describe the changes you're proposing
Currently when passing the apt_conf context variable to the template the variables will not necessarily retain their correct type. An example of this would be when using a pillar value of
nullit would be passed to the template as the string"None"instead of typeNone.If we pass the apt_conf context variables to the template using a json object the variables retain their correct types.
Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README(e.g.Available states).pillar.example.Testing checklist
state_top).Additional context