⚡ Bolt: Optimize session archiving cleanup#272
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
💡 What: Replaced O(N^2) array
.find()in chunked loops with a pre-built O(N)Maplookup and added missing try...catch block to sequential operations on same entity.🎯 Why: To fix performance degradation scaling with total sessions when archiving medium-priority sessions, which causes redundant array scans, and ensure we do not delete original file if archiving fails.
📊 Impact: Changes O(N^2) array lookup overhead inside concurrent Promise mapping into O(N) linear time for building Map and O(1) for getting session, making cleanup performant for large session counts.
🔬 Measurement: Run
bun test ./tests/unit/core/session/manager-archive.test.tsandbun run test:fullto verify safety.PR created automatically by Jules for task 16105295175900968238 started by @YoungSx