fix: ensure Chat UI layout-loading states are monotonic#64
fix: ensure Chat UI layout-loading states are monotonic#64google-labs-jules[bot] wants to merge 1 commit into
Conversation
Addresses lifecycle flaw where UI components (ActiveConversationRoot and TranscriptSurface) would be prematurely unloaded from the visual tree when a temporary blocking overlay was displayed, destroying state and hurting performance. - Added monotonic logic (`_hasLoaded...`) to `ChatConversationSurfaceProjectionCoordinator` using logical OR to ensure `ShouldLoad...` properties stay true once triggered. - Updated `ChatConversationSurfaceProjectionCoordinatorTests` to verify `ShouldLoad...` states remain true even when `ShouldShow...` evaluates to false. - Verified test coverage via `ChatViewModelTests`.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
The bug reported loading layout state regressions for the Chat component when temporary overlays are presented. As detailed in the repository lifecycle guidelines,
ShouldLoad...properties governing visual tree realizations must be kept distinct from visual visibilityShouldShow...and importantly must be monotonic (never unset) after being loaded. This fixes it inChatConversationSurfaceProjectionCoordinatorand enforces it in tests.ShouldLoadActiveConversationRootandShouldLoadTranscriptSurfacewere directly tied to visibility and lost state when overlaid.ChatConversationSurfaceProjectionCoordinatordidn't maintain internal latching for theShouldLoadprojections.dotnet test tests/SalmonEgg.Presentation.Core.Tests/SalmonEgg.Presentation.Core.Tests.csproj --configuration Debug --no-buildPR created automatically by Jules for task 5057594848030374984 started by @YoungSx