fix: make conversation layout realization monotonic#62
fix: make conversation layout realization monotonic#62google-labs-jules[bot] wants to merge 1 commit into
Conversation
Fixes an issue where `ShouldLoadActiveConversationRoot` and `ShouldLoadTranscriptSurface` would un-load when a visual blocking overlay appeared, violating Uno lifecycle rules about monotonic layout realization (`x:Load`). These properties now track if the layout has ever been shown and remain true. Updated `ChatConversationSurfaceProjectionCoordinatorTests` and `ChatViewModelTests` to assert this correct monotonic behavior.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Observed problem: The layout for the active conversation root and the transcript surface was being destroyed (unloaded) when a blocking overlay (like hydration or switching) appeared.
Root cause:
ChatConversationSurfaceProjectionCoordinatorwas mappingShouldShow...directly toShouldLoad.... When visibility toggled off due to an overlay, the layout was incorrectly unloaded.Architectural safety: The fix tracks if the control has been realized (
_hasLoaded...) and ensuresShouldLoad...states never regress to false once true. This strictly aligns with Uno Platformx:Loadmonotonic best practices and theAGENTS.mdrules without modifying existing View definitions.Verification:
dotnet build SalmonEgg.sln --configuration Debugdotnet test tests/SalmonEgg.Presentation.Core.Tests/SalmonEgg.Presentation.Core.Tests.csproj --configuration Debug --no-restore(isolated core tests passed successfully).Remaining unverified GUI-only risks:
ChatView.xamlbinds to these properties. It relies on the UI framework cleanly preserving the visual tree whenx:Loadremains true whileVisibilitybecomesCollapsed, which is standard WinUI/Uno behavior.PR created automatically by Jules for task 384248872525381554 started by @YoungSx