fix(ui): ensure layout realization is monotonic to prevent tree churn#56
fix(ui): ensure layout realization is monotonic to prevent tree churn#56google-labs-jules[bot] wants to merge 2 commits into
Conversation
The bug was that layout-realization (`ShouldLoad...` bound to `x:Load`) was tightly coupled to visibility (`ShouldShow...`). By adding a monotonic latch (`_hasLoaded... |= ...`), this fix ensures that once the Active Conversation Root or Transcript Surface is loaded into the visual tree, it is not destroyed/unloaded just because it is temporarily hidden (e.g., during a session switch or loading overlay). This addresses the daily lifecycle audit constraint: "Check that layout-loading state is not being misused as a fake visible overlay in places that should depend on actual presenter visibility." Verification: - Tested with Core tests: `dotnet test tests/SalmonEgg.Presentation.Core.Tests/SalmonEgg.Presentation.Core.Tests.csproj --configuration Debug --filter "FullyQualifiedName~ChatConversationSurfaceProjectionCoordinatorTests"` - Tested with Core tests: `dotnet test tests/SalmonEgg.Presentation.Core.Tests/SalmonEgg.Presentation.Core.Tests.csproj --configuration Debug --filter "FullyQualifiedName~ChatViewModelTests"` - Code review approved.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
The bug was that layout-realization (`ShouldLoad...` bound to `x:Load`) was tightly coupled to visibility (`ShouldShow...`). By adding a monotonic latch (`_hasLoaded... |= ...`), this fix ensures that once the Active Conversation Root or Transcript Surface is loaded into the visual tree, it is not destroyed/unloaded just because it is temporarily hidden (e.g., during a session switch or loading overlay). This addresses the daily lifecycle audit constraint: "Check that layout-loading state is not being misused as a fake visible overlay in places that should depend on actual presenter visibility." Verification: - Tested with Core tests: `dotnet test tests/SalmonEgg.Presentation.Core.Tests/SalmonEgg.Presentation.Core.Tests.csproj --configuration Debug --filter "FullyQualifiedName~ChatConversationSurfaceProjectionCoordinatorTests"` - Tested with Core tests: `dotnet test tests/SalmonEgg.Presentation.Core.Tests/SalmonEgg.Presentation.Core.Tests.csproj --configuration Debug --filter "FullyQualifiedName~ChatViewModelTests"` - Code review approved.
|
Closing during PR triage: this is a stale or duplicate layout-loading monotonicity attempt. #49 is the clean green candidate for this behavior; this PR is superseded, failing/conflicting, or mixed-scope and should not be merged as-is. |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
1 participant
The bug was that layout-realization (
ShouldLoad...bound tox:Load) was tightly coupled to visibility (ShouldShow...). By adding a monotonic latch (_hasLoaded... |= ...), this fix ensures that once the Active Conversation Root or Transcript Surface is loaded into the visual tree, it is not destroyed/unloaded just because it is temporarily hidden (e.g., during a session switch or loading overlay).This addresses the daily lifecycle audit constraint: "Check that layout-loading state is not being misused as a fake visible overlay in places that should depend on actual presenter visibility."
Verification:
dotnet test tests/SalmonEgg.Presentation.Core.Tests/SalmonEgg.Presentation.Core.Tests.csproj --configuration Debug --filter "FullyQualifiedName~ChatConversationSurfaceProjectionCoordinatorTests"dotnet test tests/SalmonEgg.Presentation.Core.Tests/SalmonEgg.Presentation.Core.Tests.csproj --configuration Debug --filter "FullyQualifiedName~ChatViewModelTests"PR created automatically by Jules for task 11779981278705227692 started by @YoungSx