Fix: Decouple layout loading state from visual overlay visibility in chat UI#52
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
Closing during PR triage: this is a stale or duplicate layout-loading monotonicity attempt. #49 is the clean green candidate for this behavior; this PR is superseded, failing/conflicting, or mixed-scope and should not be merged as-is. |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
Observed Problem:
Layout loading states (
ShouldLoadActiveConversationRoot,ShouldLoadTranscriptSurface) are regressing (un-loading) when temporary blocking overlays (like pending shell activations) are shown, which mistakenly unloads UI elements rather than just hiding them.Root Cause:
ChatConversationSurfaceProjectionCoordinatorbindsShouldLoadstates directly toShouldShowstates. Consequently, when a temporary blocking overlay hides the surface, thex:Loadlayout state becomesfalse, destructively unloading heavy chat UI elements merely because a temporary overlay became visible. This violates Uno Platform UI lifecycle principles where layout loading states should be monotonic.Why the fix is safe architecturally:
The fix introduces monotonic latching inside the scope of
ChatConversationSurfaceProjectionCoordinator. OnceShouldLoad...transitions totrue, it remainstruefor the lifecycle of the ChatView, correctly separating layout realization from visual state (ShouldShow...). It aligns with Uno/WinUI cross-platform lifecycle rules and prevents UI recreation churn without moving state into the View.Verification Commands Run:
dotnet build src/SalmonEgg.Presentation.Core/SalmonEgg.Presentation.Core.csproj --configuration Debugdotnet test tests/SalmonEgg.Presentation.Core.Tests/SalmonEgg.Presentation.Core.Tests.csproj --configuration Debug --filter "FullyQualifiedName~ChatConversationSurfaceProjectionCoordinatorTests" --no-restoredotnet test tests/SalmonEgg.Presentation.Core.Tests/SalmonEgg.Presentation.Core.Tests.csproj --configuration Debug --filter "FullyQualifiedName~ChatViewModelTests" --no-restoreRemaining Unverified GUI-only Risks:
PR created automatically by Jules for task 4296163824484501412 started by @YoungSx