Skip to content

Fix: Decouple layout loading state from visual overlay visibility in chat UI#52

Closed
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
fix/chat-overlay-loading-lifecycle-4296163824484501412
Closed

Fix: Decouple layout loading state from visual overlay visibility in chat UI#52
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
fix/chat-overlay-loading-lifecycle-4296163824484501412

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

Observed Problem:
Layout loading states (ShouldLoadActiveConversationRoot, ShouldLoadTranscriptSurface) are regressing (un-loading) when temporary blocking overlays (like pending shell activations) are shown, which mistakenly unloads UI elements rather than just hiding them.

Root Cause:
ChatConversationSurfaceProjectionCoordinator binds ShouldLoad states directly to ShouldShow states. Consequently, when a temporary blocking overlay hides the surface, the x:Load layout state becomes false, destructively unloading heavy chat UI elements merely because a temporary overlay became visible. This violates Uno Platform UI lifecycle principles where layout loading states should be monotonic.

Why the fix is safe architecturally:
The fix introduces monotonic latching inside the scope of ChatConversationSurfaceProjectionCoordinator. Once ShouldLoad... transitions to true, it remains true for the lifecycle of the ChatView, correctly separating layout realization from visual state (ShouldShow...). It aligns with Uno/WinUI cross-platform lifecycle rules and prevents UI recreation churn without moving state into the View.

Verification Commands Run:

  • dotnet build src/SalmonEgg.Presentation.Core/SalmonEgg.Presentation.Core.csproj --configuration Debug
  • dotnet test tests/SalmonEgg.Presentation.Core.Tests/SalmonEgg.Presentation.Core.Tests.csproj --configuration Debug --filter "FullyQualifiedName~ChatConversationSurfaceProjectionCoordinatorTests" --no-restore
  • dotnet test tests/SalmonEgg.Presentation.Core.Tests/SalmonEgg.Presentation.Core.Tests.csproj --configuration Debug --filter "FullyQualifiedName~ChatViewModelTests" --no-restore

Remaining Unverified GUI-only Risks:

  • FlaUI tests run separately in standard pipeline; changes to visual layout logic should be tested manually if required by UI smoke tests (although only performance/lifecycle should be visibly affected, not general behavior).

PR created automatically by Jules for task 4296163824484501412 started by @YoungSx

@google-labs-jules

Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel

vercel Bot commented Jun 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
salmonegg Ready Ready Preview, Comment Jun 6, 2026 10:34pm

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@YoungSx

YoungSx commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Closing during PR triage: this is a stale or duplicate layout-loading monotonicity attempt. #49 is the clean green candidate for this behavior; this PR is superseded, failing/conflicting, or mixed-scope and should not be merged as-is.

@YoungSx YoungSx closed this Jun 25, 2026
@google-labs-jules

Copy link
Copy Markdown
Contributor Author

Closing during PR triage: this is a stale or duplicate layout-loading monotonicity attempt. #49 is the clean green candidate for this behavior; this PR is superseded, failing/conflicting, or mixed-scope and should not be merged as-is.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant