feat: add daily lifecycle review workflow and fix layout loading leak#46
Conversation
- Added a GitHub Actions workflow `.github/workflows/jules-daily-review.yml` for automated daily audits of session lifecycle constraints. - Fixed a bug where `IsLayoutLoading` could leak and remain true indefinitely in `SelectAndHydrateConversationAsync` when a conversation activates in a hydrating state. - Unconditionally clear `IsLayoutLoading` at the end of the activation block, relying on `IsHydrating` and `IsRemoteHydrationPending` via `ChatConversationSurfaceStatePresenter` to correctly project the true overlay state. - Added `SelectAndHydrateConversationAsync_WhenHydrating_ClearsLayoutLoadingState` test to protect against regressions.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
Closing during PR triage: this is a stale or duplicate layout-loading monotonicity attempt. #49 is the clean green candidate for this behavior; this PR is superseded, failing/conflicting, or mixed-scope and should not be merged as-is. |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
1 participant
.github/workflows/jules-daily-review.ymlwith the provided prompt text to run a daily review.global.jsonso the .NET SDK version downgrade is not committed.keepLayoutLoadingfromSelectAndHydrateConversationAsyncinChatViewModel.csso it doesn't cause a stale overlay layout. Actual UI presentation correctly relies onChatConversationSurfaceStatePresenterwhich determines the visibility usingIsHydratingandIsRemoteHydrationPendingstates correctly.SelectAndHydrateConversationAsync_WhenHydrating_ClearsLayoutLoadingStatetest to ensure it remains clean.PR created automatically by Jules for task 10540182609505247278 started by @YoungSx