feat(storage): enable default CRC32C checksum validation for object downloads#7
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request implements on-the-fly hash validation for object downloads using a new HashValidatingStream decorator. The Rest connection class is updated to wrap download streams and validate them against CRC32C or MD5 headers. Feedback identifies a potential issue where seeking on the decorated stream could corrupt hash calculations, suggesting that seeking should be explicitly disabled in the HashValidatingStream class.
04cc1dd to
fa77863
Compare
fa77863 to
d52e22f
Compare
gurusai-voleti
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Enables full object checksum validation (CRC32C by default) across GCS JSON read paths, covering all four download methods:
downloadAsString,downloadToFile,downloadAsStream, anddownloadAsStreamAsync.It integrates a
HashValidatingStreamdecorator that computes hashes on-the-fly and validates them upon reaching the end of the stream.Key Features
'validate'parameter (crc32,md5, orfalseto disable).206 Partial Content) where full object validation is incompatible.Buganizer Tasks Resolved
[PHP] SDK: Full object checksum for all JSON and XML Reads as well)Testing
HashValidatingStreamTest.php.RestTest.php.