Skip to content

@W-23122929@ - feat: delete enrich_metadata MCP tool and its provider package#470

Open
kumar-aman2-general wants to merge 1 commit into
salesforcecli:mainfrom
kumar-aman2-general:W-23122929-delete-enrich-metadata
Open

@W-23122929@ - feat: delete enrich_metadata MCP tool and its provider package#470
kumar-aman2-general wants to merge 1 commit into
salesforcecli:mainfrom
kumar-aman2-general:W-23122929-delete-enrich-metadata

Conversation

@kumar-aman2-general

Copy link
Copy Markdown

What & Why

Retires the NON-GA enrich_metadata MCP tool in favor of the sanctioned portable Skill (the migration target), and deletes the 1:1 provider package that existed solely to ship it. Resolves W-23122929.

Changes

  • Deleted the entire packages/mcp-provider-metadata-enrichment/ package (src/index.ts, src/provider.ts, src/tools/enrich_metadata.ts, tests, package.json, configs).
  • Removed EnrichMetadataMcpProvider (import + instance) from MCP_PROVIDER_REGISTRY in packages/mcp/src/registry.ts.
  • Dropped the @salesforce/mcp-provider-metadata-enrichment dependency from @salesforce/mcp (packages/mcp/package.json).
  • Removed the package from CODEOWNERS and both publish workflows (publish-providers.yml, publish-mcp-server.yml).
  • Removed the "Enrichment Toolset" section from README.md.

Acceptance criteria

  • enrich_metadata.ts removed from packages/mcp-provider-metadata-enrichment/src/tools/
  • Whole package packages/mcp-provider-metadata-enrichment/ deleted
  • EnrichMetadataMcpProvider removed from MCP_PROVIDER_REGISTRY; no remaining Toolset.ENRICHMENT references for this tool
  • No other package depends on @salesforce/mcp-provider-metadata-enrichment
  • @salesforce/mcp builds without the package
  • Docs updated
  • Platform CLI team sign-off (process gate)

Verification

  • yarn build@salesforce/mcp compiles cleanly without the package.
  • yarn test — 82/82 passing in the mcp package.
  • yarn lint — 0 errors.
  • Repo-wide grep: zero remaining references to the package, provider, tool name, or Toolset.ENRICHMENT.

Note

The ENRICHMENT = 'enrichment' value in packages/mcp-provider-api/src/enums.ts was intentionally left in place — it's a value in a separately-published shared API package, so removing it is a potential breaking change for other consumers and was out of scope for this story. Happy to remove it in a follow-up if the team prefers.

🤖 Generated with Claude Code

… package

Retire the NON-GA enrich_metadata MCP tool in favor of the sanctioned
portable Skill migration target, and delete the 1:1 provider package
that existed solely to ship it.

- Delete packages/mcp-provider-metadata-enrichment/ in its entirety
- Remove EnrichMetadataMcpProvider from MCP_PROVIDER_REGISTRY
- Drop @salesforce/mcp-provider-metadata-enrichment dependency from @salesforce/mcp
- Remove package from CODEOWNERS and both publish workflows
- Remove the Enrichment Toolset section from the README

Verified: @salesforce/mcp builds and all tests pass; no remaining
references to the package, provider, tool, or Toolset.ENRICHMENT.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@salesforce-cla

Copy link
Copy Markdown

Thanks for the contribution! It looks like @kumar-aman2-general is an internal user so signing the CLA is not required. However, we need to confirm this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants