🎨 Palette: Add aria-current to active navigation links#403
🎨 Palette: Add aria-current to active navigation links#403
Conversation
- Adds `aria-current="page"` to active links in `Sidebar` and `Navbar` components. - Improves screen reader accessibility by explicitly indicating the current page. - Adds regression tests in `src/components/__tests__/Navigation.test.tsx`. - Updates `.Jules/palette.md` with accessibility learnings. Co-authored-by: saint2706 <45678566+saint2706@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Replaced explicit `any` type with `ReturnType<typeof createRoot>` in `src/components/__tests__/Navigation.test.tsx`. - Ensures compliance with linting rules and improves type safety in tests. Co-authored-by: saint2706 <45678566+saint2706@users.noreply.github.com>
- Removed unused `React` import in `src/components/__tests__/Navigation.test.tsx` to fix linting error. Co-authored-by: saint2706 <45678566+saint2706@users.noreply.github.com>
💡 What: Added
aria-current="page"to active navigation links in the Sidebar and Navbar.🎯 Why: Screen reader users rely on this attribute to know which link in a navigation menu corresponds to the current page. Visual indicators (like bold text or background color) are not sufficient for non-visual users.
♿ Accessibility:
aria-current="page"when active.aria-current="page"when active.aria-current="page"when active.✅ Verification:
src/components/__tests__/Navigation.test.tsxwhich verify the presence of the attribute.PR created automatically by Jules for task 3684024909551988662 started by @saint2706