fix: Wider Server Tiles to Fit Waiting Badge#337
Draft
sahil-noon wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a server has waiting agents, the sidebar SERVER panel tile shows the yellow waiting-rollup badge on the same row as the "N sess" count. Two sizing problems: at the desktop grid's 72px tile floor the pair overflowed the padded content box, cramming the badge against the tile edge; and because the badge pill is taller than the count text, tiles (and their whole grid row) jumped in height every time an agent started or stopped waiting. This raises the desktop tile floor to 88px (matching the mobile column width) and reserves the badge's height in the count row permanently — tile dimensions are now constant whether or not the badge is visible.
Changes
server-panel.tsx— desktop gridminmax(72px, 1fr)→minmax(88px, 1fr)server-panel.tsx— count row gets a fixedh-4(the badge pill's exact height), so badge appearance/disappearance no longer resizes the tileVerified: tsc, 1071 unit tests, server-panel-grid e2e (5/5), and a live before/after measurement with an injected waiting state — tile bounding box is byte-identical (97.5×47.75) with and without the badge.
🤖 Generated with Claude Code