Repository navigation
fix: parse the LLM query array as JSON instead of splitting on commas - #134
Merged
Merged
Conversation
sahenjp
pushed a commit
that referenced
this pull request
Nov 11, 2026
🤖 I have created a release *beep* *boop* --- ## [0.31.2](v0.31.1...v0.31.2) (2026-11-11) ### Bug Fixes * parse the LLM query array as JSON instead of splitting on commas ([#134](#134)) ([fee1a93](fee1a93)) * update rustix to 1.1.6 for RUSTSEC-2026-0486 ([c07945e](c07945e)) * validate timeout_limit at the HTTP entry point instead of panicking on inf ([#135](#135)) ([f318d72](f318d72)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parse the planned-query array in the deep research endpoint with
serde_jsoninstead of splitting the array body on commas, as prescribed by A14 indocs/AUDIT-2026-11-02.md.Root cause
parse_string_arrayinsrc/deep_research.rsextracted the text between the brackets and split it on,, then trimmed quote characters from each fragment. Any valid JSON string entry containing a comma (for example"Paris, Texas population") was split into fragments, and escaped quotes inside entries were mangled.Changes
serde_json::from_str::<Vec<String>>.No dependencies, configuration, or response fields change;
serde_jsonis already a dependency.Verification
Linux x86_64, Rust 1.99.1:
cargo test --all-targets deep_research: 8 passed (5 existing + 3 new).cargo test --all-targets: 1110 passed, 1 failed. The failure istests/pdf_pages.rs(Japanese PDF text extraction), which needs Poppler Japanese CMap data that is not installed in this sandbox; it fails identically on unmodifiedmainand is unrelated to this change. Proxy environment variables were excluded from the test process for the loopback fixtures, as in fix: reject executable schemes in search results #52.cargo fmt --all --check: passed.cargo clippy --all-targets -- -D warnings: passed.Limitations
Other platforms are left to CI.
Related
Addresses A14 in the existing audit.
AI assistance: implementation and regression tests.