Sprint 2 — UX fixes, staging env, admin tools, player sync improvements by saggacce · Pull Request #177 · saggacce/Predecessor-Build

saggacce · 2026-05-14T14:45:00Z

Sprint PR — Sprint 2

Cambios incluidos

Player Scouting

Auto-sync al abrir un perfil sin snapshot (datos aparecen sin Refresh)
Refresh visible para todos los roles (no solo pred.gg OAuth)
Refresh ahora sincroniza perfil + partidas recientes + event stream

Platform Admin

Reset de contraseña de usuarios desde el panel
Sync endpoints usan credenciales almacenadas como fallback (no requieren OAuth activo)

Infraestructura

Entorno de staging local: ./serve.sh staging — nginx + build real desde rama develop
Sprint testing issue se crea automáticamente al abrir sprint PR
Issue de testing reabre si se cierra con checkboxes pendientes
nginx timeout en producción → 1800s (sync masivo no da 504)

Organización

Roadmap migrado a GitHub Issues con labels, milestones y Project
future_features_roadmap.md eliminado (GitHub es la fuente de verdad)
Ramas limpias: solo main y develop

Testing

Issue de testing se creará automáticamente al abrir este PR.

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

All roadmap items migrated to GitHub Issues #160-#172 with labels, milestones (Sprint 2, Sprint 3, Backlog) and GitHub Project board. GitHub is now the single source of truth for roadmap management. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- POST /admin/users/:id/reset-password with bcrypt hash - KeyRound button in user list (disabled for own account) - Modal with password field (min 8 chars) and confirmation - resetPassword() added to apiClient.admin Closes #173 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- serve.sh staging: build frontend + start Express :3002 + nginx :8080 - serve.sh staging-stop / staging-status - .env.staging template (gitignored) - Mirrors production config: NODE_ENV=production, nginx proxy, PM2-like Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

./serve.sh staging now fetches origin/develop and runs from /tmp/riftline-staging — always reflects the real develop state, not local uncommitted changes. Worktree cleaned up on staging-stop. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…redentials - POST /players/sync falls back to stored predgg_refresh_token when no user OAuth token (allows MANAGER/COACH/PLAYER to refresh player profiles) - Refresh button shown for internalAuthenticated (any logged-in user) instead of authenticated (pred.gg OAuth only) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

When a player profile is opened and has no snapshot data (generalStats empty), automatically triggers the same sync as the Refresh button. User sees data appear without having to click anything. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

POST /players/sync now: 1. Syncs player profile and creates snapshot (immediate, blocking) 2. Syncs recent matches + event stream in background (non-blocking) After clicking Refresh on a player profile, all new matches and their timeline/analysis data appear automatically within seconds. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5a19e57df0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-05-14T14:46:53Z

+    if (!userToken) {
+      try {
+        const cred = await db.platformCredential.findUnique({ where: { key: 'predgg_refresh_token' } });
+        if (cred) {
+          const result = await exchangeToken({ grant_type: 'refresh_token', refresh_token: cred.value });
+          if (result.ok && result.data.access_token) userToken = result.data.access_token;


Require auth before using platform sync token

Because /players/sync is still registered without requireAuth, this fallback lets any unauthenticated caller exchange the stored predgg_refresh_token and run player + recent-match syncs against the database. The rest of the app mounts playersRouter directly (apps/api/src/index.ts) with no global auth, so a public POST can now consume the platform credential/quota and write arbitrary synced players; gate this fallback/route behind internal auth or admin authorization before reading the stored credential.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-05-14T14:46:53Z

+    "$STAGING_DIR/node_modules/.bin/tsx" "$STAGING_DIR/apps/api/src/index.ts" \
+      >> "$STAGING_LOG" 2>&1 &


Pass staging env values when launching the API

The staging command advertises API :3002 and a production-like built frontend, but this launch relies on .env.staging to provide PORT and NODE_ENV; copying from .env.example leaves both unset. In that common setup the API uses its default process.env.PORT ?? '3001' (apps/api/src/index.ts:41) and skips the production static serving//api rewrite, so wait_for_port 3002 fails or staging serves the wrong mode. Prefix the command with PORT=$STAGING_API_PORT NODE_ENV=production (or export them explicitly) instead of relying on hidden env file keys.

Useful? React with 👍 / 👎.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…precise check - Remove internalAuthenticated check (race condition with async auth state) - Check typeof matches === 'number' instead of Object.keys empty check (handles partial snapshots with favRole/favHero but missing numeric stats) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

… missing When no snapshot exists or snapshot has no match data, calculate MATCHES, WIN RATE, KDA and HERO DAMAGE directly from the MatchPlayer records already loaded for the profile. This works without pred.gg API call and shows data immediately on first load. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Replace IIFE with explicit variable computed before the return statement. The IIFE was silently returning {} despite matchPlayers being available. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…ing start - Compute generalStats as explicit variable before return (IIFE had tsx cache issue) - Clear ~/.cache/tsx on each staging start to ensure latest code runs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

BUG-001: generalStats empty (tsx cache + IIFE issue) BUG-002: staging serving old code (tsx cache) BUG-003: upgrade-insecure-requests blocks fetch on HTTP BUG-004: secure cookies rejected over HTTP Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

github-actions · 2026-05-14T16:08:03Z

🧪 Testing requerido

Se ha creado el issue de testing: #179

Completa el checklist y cierra el issue antes de aprobar el deploy en producción.

→ #179

saggacce and others added 10 commits May 14, 2026 14:45

fix: sprint testing issue — add synchronize trigger + dedup check

6dfab5b

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat: reopen testing issue if closed with unchecked boxes

66a5d7e

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Merge branch 'main' into develop

5ba18c9

github-actions Bot mentioned this pull request May 14, 2026

🧪 Testing requerido — Sprint PR #177 #178

Closed

8 tasks

chatgpt-codex-connector Bot reviewed May 14, 2026

View reviewed changes

saggacce and others added 7 commits May 14, 2026 16:49

fix: sprint-testing workflow needs pull-requests: write to comment on PR

bedf262

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix: testing issue specifies staging (localhost:8080) not production

62a4417

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix: compute generalStats before return — avoid IIFE closure issue

d10e575

Replace IIFE with explicit variable computed before the return statement. The IIFE was silently returning {} despite matchPlayers being available. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

github-actions Bot mentioned this pull request May 14, 2026

🧪 Testing requerido — Sprint PR #177 #179

Open

8 tasks

saggacce merged commit 819094e into main May 14, 2026
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sprint 2 — UX fixes, staging env, admin tools, player sync improvements#177

Sprint 2 — UX fixes, staging env, admin tools, player sync improvements#177
saggacce merged 17 commits into
mainfrom
develop

saggacce commented May 14, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot May 14, 2026

Uh oh!

chatgpt-codex-connector Bot May 14, 2026

Uh oh!

github-actions Bot commented May 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		"$STAGING_DIR/node_modules/.bin/tsx" "$STAGING_DIR/apps/api/src/index.ts" \
		>> "$STAGING_LOG" 2>&1 &

Conversation

saggacce commented May 14, 2026

Sprint PR — Sprint 2

Cambios incluidos

Testing

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 14, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot May 14, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented May 14, 2026

🧪 Testing requerido

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant